You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/04/15 02:21:34 UTC
[GitHub] [druid] jihoonson edited a comment on issue #9701:
DruidLeaderClient always thinks the first node returned from
DruidNodeDiscovery is the leader
jihoonson edited a comment on issue #9701: DruidLeaderClient always thinks the first node returned from DruidNodeDiscovery is the leader
URL: https://github.com/apache/druid/issues/9701#issuecomment-613776169
When it tries to follow redirects, [it checks the current known leader](https://github.com/apache/druid/blob/cda9f41e69ebc0513782805fca9ead378c1910ab/server/src/main/java/org/apache/druid/discovery/DruidLeaderClient.java#L282-L294) which calls `pickOneHost()`. Before #9481, this function used to use `ServerDiscoverySelector` which returns the known leader and fall back to `DruidNodeDiscovery` when there is no known leader, but now it always returns the first node from `DruidNodeDiscovery`.
https://github.com/apache/druid/blob/cda9f41e69ebc0513782805fca9ead378c1910ab/server/src/main/java/org/apache/druid/discovery/DruidLeaderClient.java#L297-L307
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org