You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2024/05/04 21:00:32 UTC

[PR] add k8s port check [pekko-samples]

pjfanning opened a new pull request, #106:
URL: https://github.com/apache/pekko-samples/pull/106

   see https://github.com/apache/pekko-samples/issues/103


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] add k8s port check [pekko-samples]

Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on code in PR #106:
URL: https://github.com/apache/pekko-samples/pull/106#discussion_r1596721696


##########
pekko-sample-cluster-kubernetes-scala/src/main/resources/application.conf:
##########
@@ -29,4 +29,9 @@ pekko.management {
       example-ready = org.apache.pekko.sample.cluster.kubernetes.DemoHealthCheck
     }
   }
+  # Add these so the pods won't get killed.
+  http {
+    port = 8558

Review Comment:
   ```suggestion
       port = 7626
   ```



##########
pekko-sample-cluster-kubernetes-java/src/main/resources/application.conf:
##########
@@ -33,4 +33,9 @@ pekko.management {
       example-ready = org.apache.pekko.cluster.bootstrap.demo.DemoHealthCheck
     }
   }
+  # Add these so the pods won't get killed.
+  http {
+    port = 8558

Review Comment:
   ```suggestion
       port = 7626
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] add k8s port check [pekko-samples]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #106:
URL: https://github.com/apache/pekko-samples/pull/106#discussion_r1596738046


##########
pekko-sample-cluster-kubernetes-java/src/main/resources/application.conf:
##########
@@ -33,4 +33,9 @@ pekko.management {
       example-ready = org.apache.pekko.cluster.bootstrap.demo.DemoHealthCheck
     }
   }
+  # Expose port for Kubernetes health check probing.

Review Comment:
   looks good now - thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] add k8s port check [pekko-samples]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #106:
URL: https://github.com/apache/pekko-samples/pull/106


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] add k8s port check [pekko-samples]

Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on code in PR #106:
URL: https://github.com/apache/pekko-samples/pull/106#discussion_r1590472128


##########
pekko-sample-cluster-kubernetes-java/src/main/resources/application.conf:
##########
@@ -33,4 +33,9 @@ pekko.management {
       example-ready = org.apache.pekko.cluster.bootstrap.demo.DemoHealthCheck
     }
   }
+  # Add these so the pods won't get killed.
+  http {
+    port = 8558

Review Comment:
   You should set it to bind-port instead of port.
   
   https://github.com/apache/pekko-management/blob/1b7a52ba277daec3130baee4bf29a2f0f55a51bb/management/src/main/resources/reference.conf#L33
   
   If the user does not want to change, they just need to set it to pekko-management port in the k8s health check.(is 7626 not 8558)
   
   https://github.com/apache/pekko-management/blob/1b7a52ba277daec3130baee4bf29a2f0f55a51bb/management/src/main/resources/reference.conf#L19



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] add k8s port check [pekko-samples]

Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on code in PR #106:
URL: https://github.com/apache/pekko-samples/pull/106#discussion_r1596736920


##########
pekko-sample-cluster-kubernetes-java/src/main/resources/application.conf:
##########
@@ -33,4 +33,9 @@ pekko.management {
       example-ready = org.apache.pekko.cluster.bootstrap.demo.DemoHealthCheck
     }
   }
+  # Expose port for Kubernetes health check probing.

Review Comment:
   Sorry, I forgot the comment should be clarity. I have updated this in the commit, I hope you don't mind.
   
   And then I think this is ready for review.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] add k8s port check [pekko-samples]

Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on code in PR #106:
URL: https://github.com/apache/pekko-samples/pull/106#discussion_r1590472128


##########
pekko-sample-cluster-kubernetes-java/src/main/resources/application.conf:
##########
@@ -33,4 +33,9 @@ pekko.management {
       example-ready = org.apache.pekko.cluster.bootstrap.demo.DemoHealthCheck
     }
   }
+  # Add these so the pods won't get killed.
+  http {
+    port = 8558

Review Comment:
   You could also set it to bind-port instead of port(port is fine too).
   
   https://github.com/apache/pekko-management/blob/1b7a52ba277daec3130baee4bf29a2f0f55a51bb/management/src/main/resources/reference.conf#L33
   
   If the user does not want to change, they just need to set it to pekko-management port in the k8s health check.(is 7626 not 8558)
   
   https://github.com/apache/pekko-management/blob/1b7a52ba277daec3130baee4bf29a2f0f55a51bb/management/src/main/resources/reference.conf#L19



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] add k8s port check [pekko-samples]

Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on code in PR #106:
URL: https://github.com/apache/pekko-samples/pull/106#discussion_r1596736920


##########
pekko-sample-cluster-kubernetes-java/src/main/resources/application.conf:
##########
@@ -33,4 +33,9 @@ pekko.management {
       example-ready = org.apache.pekko.cluster.bootstrap.demo.DemoHealthCheck
     }
   }
+  # Expose port for Kubernetes health check probing.

Review Comment:
   Sorry, I forgot the comment should be clarity. I have updated this in the commit, I hope you don't mind.
   
   And then I think this is ready for review. 
   
   Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org