You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/10/27 10:20:20 UTC

[GitHub] [iotdb] stormbroken commented on a change in pull request #4244: [IOTDB-1745] Metagroup snapshots support template

stormbroken commented on a change in pull request #4244:
URL: https://github.com/apache/iotdb/pull/4244#discussion_r737322149



##########
File path: server/src/main/java/org/apache/iotdb/db/metadata/template/TemplateManager.java
##########
@@ -79,6 +79,17 @@ public Template getTemplate(String templateName) throws UndefinedTemplateExcepti
     return template;
   }
 
+  public void setTemplateMap(Map<String, Template> templateMap) {

Review comment:
       From my perspective, I think this way may result in less memory leak? and minimize some possible unexpected external modification.
   Besides, this way maybe not block the gc of snapshot




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org