[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #10296: ipv6_setsockopt: remove redundant logic

["pkarashchenko (via GitHub)" <gi...@apache.org>]

pkarashchenko commented on code in PR #10296:
URL: https://github.com/apache/nuttx/pull/10296#discussion_r1298724905


##########
net/inet/ipv6_setsockopt.c:
##########
@@ -86,28 +86,17 @@ int ipv6_setsockopt(FAR struct socket *psock, int option,
       /* Handle MLD-related socket options */
 
       case IPV6_JOIN_GROUP:       /* Join a multicast group */
-        {
-          FAR const struct ipv6_mreq *mrec ;
-
-          mrec = (FAR const struct ipv6_mreq *)value;
-          ret = mld_joingroup(mrec);
-        }
+        ret = mld_joingroup(value);

Review Comment:
   I'm really not sure about this. I think cast from/to `void *` do not require additional type cast



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org