You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@stdcxx.apache.org by ab...@apache.org on 2008/04/01 17:36:26 UTC

svn commit: r643448 - /stdcxx/trunk/etc/config/windows/run_locale_utils.wsf

Author: ablack
Date: Tue Apr  1 08:36:22 2008
New Revision: 643448

URL: http://svn.apache.org/viewvc?rev=643448&view=rev
Log:
2008-04-01  Andrew Black  <ab...@roguewave.com>

	* etc/config/windows/run_locale_utils.wsf (run_locale_utils):
	Replication of r643435 for Windows. (Update result footer format to
	match format expected by exec utility. Footer search logic changed
	in r643120.)


Modified:
    stdcxx/trunk/etc/config/windows/run_locale_utils.wsf

Modified: stdcxx/trunk/etc/config/windows/run_locale_utils.wsf
URL: http://svn.apache.org/viewvc/stdcxx/trunk/etc/config/windows/run_locale_utils.wsf?rev=643448&r1=643447&r2=643448&view=diff
==============================================================================
--- stdcxx/trunk/etc/config/windows/run_locale_utils.wsf (original)
+++ stdcxx/trunk/etc/config/windows/run_locale_utils.wsf Tue Apr  1 08:36:22 2008
@@ -711,14 +711,15 @@
     {
         var pcnt = 100 * (assertions - failedassertions) / assertions;
         pcnt = Math.floor(pcnt + 0.5);
-        outstrm.WriteLine("# +-----------------------+--------+--------+--------+");
-        outstrm.WriteLine("# | DIAGNOSTIC            | ACTIVE |  TOTAL |INACTIVE|");
-        outstrm.WriteLine("# +-----------------------+--------+--------+--------+");
-        outstrm.WriteLine("# | (S7) ASSERTION        | " + FormatNumber(failedassertions, 6)
-            + " | " + FormatNumber(assertions, 6) + " | " + FormatNumber(pcnt, 5) + "% |");
-        outstrm.WriteLine("# +-----------------------+--------+--------+--------+");
+        outstrm.WriteLine("# +-----------------------+----------+----------+----------+");
+        outstrm.WriteLine("# | DIAGNOSTIC            |  ACTIVE  |   TOTAL  | INACTIVE |");
+        outstrm.WriteLine("# +-----------------------+----------+----------+----------+");
+        outstrm.WriteLine("# | (S7) ASSERTION        | " + FormatNumber(failedassertions, 8)
+            + " | " + FormatNumber(assertions, 8) + " | " + FormatNumber(pcnt, 7) + "% |");
+        outstrm.WriteLine("# +-----------------------+----------+----------+----------+");
         outstrm.WriteLine();
     }
+    outstrm.WriteLine("## Warnings = 0");
     outstrm.WriteLine("## Assertions = " + assertions);
     outstrm.WriteLine("## FailedAssertions = " + failedassertions);
     outstrm.WriteLine();



Re: svn commit: r643448 - /stdcxx/trunk/etc/config/windows/run_locale_utils.wsf

Posted by Andrew Black <ab...@roguewave.com>.
Martin Sebor wrote:
> ablack@apache.org wrote:
>> Author: ablack
>> Date: Tue Apr  1 08:36:22 2008
>> New Revision: 643448
>>
>> URL: http://svn.apache.org/viewvc?rev=643448&view=rev
>> Log:
>> 2008-04-01  Andrew Black  <ab...@roguewave.com>
>>
>>     * etc/config/windows/run_locale_utils.wsf (run_locale_utils):
>>     Replication of r643435 for Windows. (Update result footer format to
>>     match format expected by exec utility. Footer search logic changed
>>     in r643120.)
> 
> Does this by any chance fix the recent failures in locale tests?
> E.g., In these builds:
> 
> http://people.apache.org/~sebor/stdcxx/results/hpux-11.11-pa-acc-3.73-11S-643226-log.gz.txt
> 
> http://people.apache.org/~sebor/stdcxx/results/linux_redhat_el-3.8-em64t-gcc-3.2.3-11d-643226-log.gz.txt
> 

That's the intent (Well, r643435 is actually the change which fixes the
referenced builds, with r643448 fixing the windows builds which
exhibited the same problem.).  I checked the unix change locally before
checking it into subversion.

What happened is that r643120 altered the test parser to look for the
string '| INACTIVE |\n# +' when it was searching for the start of the
result header, but the test scripts were outputting '|INACTIVE|\n# +',
so a match wasn't found, producing the format messages.

--Andrew Black

> 
> Martin

Re: svn commit: r643448 - /stdcxx/trunk/etc/config/windows/run_locale_utils.wsf

Posted by Martin Sebor <se...@roguewave.com>.
ablack@apache.org wrote:
> Author: ablack
> Date: Tue Apr  1 08:36:22 2008
> New Revision: 643448
> 
> URL: http://svn.apache.org/viewvc?rev=643448&view=rev
> Log:
> 2008-04-01  Andrew Black  <ab...@roguewave.com>
> 
> 	* etc/config/windows/run_locale_utils.wsf (run_locale_utils):
> 	Replication of r643435 for Windows. (Update result footer format to
> 	match format expected by exec utility. Footer search logic changed
> 	in r643120.)

Does this by any chance fix the recent failures in locale tests?
E.g., In these builds:

http://people.apache.org/~sebor/stdcxx/results/hpux-11.11-pa-acc-3.73-11S-643226-log.gz.txt
http://people.apache.org/~sebor/stdcxx/results/linux_redhat_el-3.8-em64t-gcc-3.2.3-11d-643226-log.gz.txt

Martin

> 
> 
> Modified:
>     stdcxx/trunk/etc/config/windows/run_locale_utils.wsf
> 
> Modified: stdcxx/trunk/etc/config/windows/run_locale_utils.wsf
> URL: http://svn.apache.org/viewvc/stdcxx/trunk/etc/config/windows/run_locale_utils.wsf?rev=643448&r1=643447&r2=643448&view=diff
> ==============================================================================
> --- stdcxx/trunk/etc/config/windows/run_locale_utils.wsf (original)
> +++ stdcxx/trunk/etc/config/windows/run_locale_utils.wsf Tue Apr  1 08:36:22 2008
> @@ -711,14 +711,15 @@
>      {
>          var pcnt = 100 * (assertions - failedassertions) / assertions;
>          pcnt = Math.floor(pcnt + 0.5);
> -        outstrm.WriteLine("# +-----------------------+--------+--------+--------+");
> -        outstrm.WriteLine("# | DIAGNOSTIC            | ACTIVE |  TOTAL |INACTIVE|");
> -        outstrm.WriteLine("# +-----------------------+--------+--------+--------+");
> -        outstrm.WriteLine("# | (S7) ASSERTION        | " + FormatNumber(failedassertions, 6)
> -            + " | " + FormatNumber(assertions, 6) + " | " + FormatNumber(pcnt, 5) + "% |");
> -        outstrm.WriteLine("# +-----------------------+--------+--------+--------+");
> +        outstrm.WriteLine("# +-----------------------+----------+----------+----------+");
> +        outstrm.WriteLine("# | DIAGNOSTIC            |  ACTIVE  |   TOTAL  | INACTIVE |");
> +        outstrm.WriteLine("# +-----------------------+----------+----------+----------+");
> +        outstrm.WriteLine("# | (S7) ASSERTION        | " + FormatNumber(failedassertions, 8)
> +            + " | " + FormatNumber(assertions, 8) + " | " + FormatNumber(pcnt, 7) + "% |");
> +        outstrm.WriteLine("# +-----------------------+----------+----------+----------+");
>          outstrm.WriteLine();
>      }
> +    outstrm.WriteLine("## Warnings = 0");
>      outstrm.WriteLine("## Assertions = " + assertions);
>      outstrm.WriteLine("## FailedAssertions = " + failedassertions);
>      outstrm.WriteLine();
> 
>