You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@commons.apache.org by rspilker <gi...@git.apache.org> on 2017/10/05 22:53:21 UTC
[GitHub] commons-compress pull request #54: Let parseName stop at first NUL
GitHub user rspilker opened a pull request:
https://github.com/apache/commons-compress/pull/54
Let parseName stop at first NUL
Fixes COMPRESS-421
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rspilker/commons-compress master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-compress/pull/54.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #54
----
commit b2f89807e7a93ce7197fe935531a5158c8ef880a
Author: Roel Spilker <r....@gmail.com>
Date: 2017-10-05T22:50:23Z
Let parseName stop at first NUL
Fixes COMPRESS-421
----
---
[GitHub] commons-compress pull request #54: Let parseName stop at first NUL
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/commons-compress/pull/54
---
[GitHub] commons-compress issue #54: Let parseName stop at first NUL
Posted by rspilker <gi...@git.apache.org>.
Github user rspilker commented on the issue:
https://github.com/apache/commons-compress/pull/54
I suspect that the coverage went down. not because I added untested lines, but because I reduced the number of lines in the file.
---
[GitHub] commons-compress issue #54: Let parseName stop at first NUL
Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on the issue:
https://github.com/apache/commons-compress/pull/54
Don't worry about the coverage too much, it also depends on which JDK build of travis has finished first and fed the results into coveralls.
I vaguely recall there is a reason why we look for the last NUL, will have to re-read the code, the tar spec(s) and maybe even the code history.
---
[GitHub] commons-compress issue #54: Let parseName stop at first NUL
Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on the issue:
https://github.com/apache/commons-compress/pull/54
The reason is not buried inside the spec, it merely seems to have been a performance optimization. Before introducing the encoding support we've been looking for NUL from the start of the name fields and I changed it with 69ceb4e many moons ago.
I'll apply this PR, many thanks!
---
[GitHub] commons-compress issue #54: Let parseName stop at first NUL
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-compress/pull/54
[](https://coveralls.io/builds/13593773)
Coverage decreased (-0.03%) to 85.911% when pulling **b2f89807e7a93ce7197fe935531a5158c8ef880a on rspilker:master** into **1c016cb02a82f0372e43571e72cf52de76696ae6 on apache:master**.
---
[GitHub] commons-compress issue #54: Let parseName stop at first NUL
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-compress/pull/54
[](https://coveralls.io/builds/13593924)
Coverage decreased (-0.03%) to 85.911% when pulling **cffee1f36514fcb693c996a86b0bd869b7dd9caa on rspilker:master** into **1c016cb02a82f0372e43571e72cf52de76696ae6 on apache:master**.
---