You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by dolphy17 <gi...@git.apache.org> on 2017/10/05 18:59:32 UTC

[GitHub] zookeeper pull request #392: ZOOKEEPER-2914 compiler warning using java 9

GitHub user dolphy17 opened a pull request:

    https://github.com/apache/zookeeper/pull/392

    ZOOKEEPER-2914 compiler warning using java 9

    Replaced deprecated methods (Class.newInstance()) and removed redundant cast

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dolphy17/zookeeper ZOOKEEPER-2914

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/392.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #392
    
----
commit b2d400bc094afead646a56ab3edadfa5166f13ad
Author: Andor Molnar <an...@cloudera.com>
Date:   2017-10-05T18:57:18Z

    Replaced Class.newInstance() methods (deprecated in Java 9) with Constructor.newInstance()

----


---

[GitHub] zookeeper issue #392: ZOOKEEPER-2914 compiler warning using java 9

Posted by phunt <gi...@git.apache.org>.

Github user phunt commented on the issue:

    https://github.com/apache/zookeeper/pull/392
  
    Thanks @dolphy17 - I will look at this, but I already noticed that it's not applying to branch-3.4 (it does apply cleanly to branch-3.5 and trunk) - can you submit a separate pull request for branch-3.4?


---

[GitHub] zookeeper issue #392: ZOOKEEPER-2914 compiler warning using java 9

Posted by dolphy17 <gi...@git.apache.org>.

Github user dolphy17 commented on the issue:

    https://github.com/apache/zookeeper/pull/392
  
    Thanks for looking into @phunt 
    #393 has been created for branch-3.4 (a little bit trickier than trunk), please a take a look also.


---

[GitHub] zookeeper issue #392: ZOOKEEPER-2914 compiler warning using java 9

Posted by phunt <gi...@git.apache.org>.

Github user phunt commented on the issue:

    https://github.com/apache/zookeeper/pull/392
  
    Thanks @dolphy17 ! Committed to trunk/branch3.5 (separate PR for branch-3.4 also committed)


---

[GitHub] zookeeper pull request #392: ZOOKEEPER-2914 compiler warning using java 9

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zookeeper/pull/392


---