You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by StefanRRichter <gi...@git.apache.org> on 2017/08/07 14:26:53 UTC
[GitHub] flink pull request #4491: [FLINK-7362] [checkpoints] Savepoint property is l...
GitHub user StefanRRichter opened a pull request:
https://github.com/apache/flink/pull/4491
[FLINK-7362] [checkpoints] Savepoint property is lost after de/serial…
…ization of CheckpointProperties
## What is the purpose of the change
This PR fixes lost information about the savepoint property when de/serializing `CheckpointProperty`. The problem was caused by serialization in connection with a singleton that was checked for referencial equality to derive the savepoint property.
## Brief change log
This makes the savepoint property explicit as a boolean field in `CheckpointProperty`.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage. Nevertheless I added a small test.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
## Documentation
- Does this pull request introduce a new feature? (no)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/StefanRRichter/flink serializable-savepoint-property
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4491.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4491
----
commit 64eb3abb55f515252069371f7dd8f874b9c73c7e
Author: Stefan Richter <s....@data-artisans.com>
Date: 2017-08-07T14:22:32Z
[FLINK-7362] [checkpoints] Savepoint property is lost after de/serialization of CheckpointProperties
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4491: [FLINK-7362] [checkpoints] Savepoint property is l...
Posted by StefanRRichter <gi...@git.apache.org>.
Github user StefanRRichter closed the pull request at:
https://github.com/apache/flink/pull/4491
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4491: [FLINK-7362] [checkpoints] Savepoint property is lost aft...
Posted by StefanRRichter <gi...@git.apache.org>.
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/4491
CC @aljoscha
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4491: [FLINK-7362] [checkpoints] Savepoint property is l...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4491#discussion_r131751111
--- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointProperties.java ---
@@ -225,6 +230,7 @@ public String toString() {
return "CheckpointProperties{" +
"forced=" + forced +
", externalize=" + externalizeCheckpoint() +
+ ", externalize=" + savepoint +
--- End diff --
copy error: should be "savepoint"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4491: [FLINK-7362] [checkpoints] Savepoint property is lost aft...
Posted by StefanRRichter <gi...@git.apache.org>.
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/4491
Merged in 843f0cbc10
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4491: [FLINK-7362] [checkpoints] Savepoint property is lost aft...
Posted by StefanRRichter <gi...@git.apache.org>.
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/4491
Thanks for the review @aljoscha ! I addressed your comment and will merge now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4491: [FLINK-7362] [checkpoints] Savepoint property is lost aft...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4491
This looks good, modulo the slight copying error! 👍
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---