[GitHub] [superset] zhaoyongjie commented on a change in pull request #17680: fix: replace datamask with key from new key value api

[GitBox <gi...@apache.org>]

zhaoyongjie commented on a change in pull request #17680:
URL: https://github.com/apache/superset/pull/17680#discussion_r766761326



##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/state.ts
##########
@@ -88,7 +88,6 @@ export const useFilterUpdates = (
 ) => {
   const filters = useFilters();
   const dataMaskApplied = useNativeFiltersDataMask();
-

Review comment:
       Could we remove the unnecessary change? 

##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/utils.ts
##########
@@ -69,7 +69,6 @@ export const checkIsApplyDisabled = (
 ) => {
   const dataSelectedValues = Object.values(dataMaskSelected);
   const dataAppliedValues = Object.values(dataMaskApplied);
-

Review comment:
       Could we remove the unnecessary change? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org