You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2017/03/01 18:05:26 UTC
[kudu-CR](branch-1.2.x) KUDU-1880 Prevent eager ignoring of NULLs
Andrew Wong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6202
Change subject: KUDU-1880 Prevent eager ignoring of NULLs
......................................................................
KUDU-1880 Prevent eager ignoring of NULLs
During a nullable block scan, if a NULL set of cells is reached before
the decoder evaluation is disabled (e.g. if the first rows in the
block are NULL), the rows will be prematurely marked as not in the
results set. If evaluating an IsNull predicate, this will yield
erroneous results.
This patch adds an API to the materialization context that indicates
whether it is evaluating an IsNull predicate. If it is, the null rows
must not be removed from the results set. Otherwise, null rows can be
cleared immediately.
Additional tablet unit tests are added to cover the IsNull case with
NULL values at the beginning of columns for various types. These
tests will fail without the fixes in the patch and pass with them.
Change-Id: Ib418a4fcc2794ce2f686e864f51834fb4fb8b048
---
M src/kudu/cfile/cfile_reader.cc
M src/kudu/common/column_materialization_context.h
M src/kudu/common/partial_row.h
M src/kudu/tablet/CMakeLists.txt
A src/kudu/tablet/all_types-scan-correctness-test.cc
5 files changed, 316 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/6202/1
--
To view, visit http://gerrit.cloudera.org:8080/6202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib418a4fcc2794ce2f686e864f51834fb4fb8b048
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR](branch-1.2.x) KUDU-1880 Prevent eager ignoring of NULLs
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has uploaded a new patch set (#2).
Change subject: KUDU-1880 Prevent eager ignoring of NULLs
......................................................................
KUDU-1880 Prevent eager ignoring of NULLs
During a nullable block scan, if a NULL set of cells is reached before
the decoder evaluation is disabled (e.g. if the first rows in the
block are NULL), the rows will be prematurely marked as not in the
results set. If evaluating an IsNull predicate, this will yield
erroneous results.
This patch adds an API to the materialization context that indicates
whether it is evaluating an IsNull predicate. If it is, the null rows
must not be removed from the results set. Otherwise, null rows can be
cleared immediately.
Additional tablet unit tests are added to cover the IsNull case with
NULL values at the beginning of columns for various types. These
tests will fail without the fixes in the patch and pass with them.
Change-Id: Ib418a4fcc2794ce2f686e864f51834fb4fb8b048
---
M src/kudu/cfile/cfile_reader.cc
M src/kudu/common/column_materialization_context.h
M src/kudu/common/partial_row.h
M src/kudu/tablet/CMakeLists.txt
A src/kudu/tablet/all_types-scan-correctness-test.cc
5 files changed, 314 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/6202/2
--
To view, visit http://gerrit.cloudera.org:8080/6202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib418a4fcc2794ce2f686e864f51834fb4fb8b048
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR](branch-1.2.x) KUDU-1880 Prevent eager ignoring of NULLs
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has abandoned this change.
Change subject: KUDU-1880 Prevent eager ignoring of NULLs
......................................................................
Abandoned
This patch hinges on the presence of IsNull predicates, which are not in 1.2.x.
--
To view, visit http://gerrit.cloudera.org:8080/6202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ib418a4fcc2794ce2f686e864f51834fb4fb8b048
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins