You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2023/11/23 02:22:05 UTC
[native-toolchain-CR] IMPALA-11157: Build native Hadoop libraries for aarch64
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20724
Change subject: IMPALA-11157: Build native Hadoop libraries for aarch64
......................................................................
IMPALA-11157: Build native Hadoop libraries for aarch64
Builds native Hadoop libraries for aarch64 for use as client libraries
in Impala. CDP builds on aarch64 are not yet available; this allows us
to build and test Impala by swapping in aarch64 versions of native
libraries.
Change-Id: Ib3c5576f7decadc4568d70d5520881a314d8ee14
---
M buildall.sh
A source/hadoop/build.sh
2 files changed, 87 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/24/20724/1
--
To view, visit http://gerrit.cloudera.org:8080/20724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib3c5576f7decadc4568d70d5520881a314d8ee14
Gerrit-Change-Number: 20724
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] IMPALA-11157: Build native Hadoop libraries for aarch64
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20724 )
Change subject: IMPALA-11157: Build native Hadoop libraries for aarch64
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/20724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3c5576f7decadc4568d70d5520881a314d8ee14
Gerrit-Change-Number: 20724
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 29 Nov 2023 18:37:51 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11157: Build native Hadoop libraries for aarch64
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20724 )
Change subject: IMPALA-11157: Build native Hadoop libraries for aarch64
......................................................................
Patch Set 2:
Verified in https://jenkins.impala.io/job/ubuntu-20.04-from-scratch-ARM/59/.
--
To view, visit http://gerrit.cloudera.org:8080/20724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3c5576f7decadc4568d70d5520881a314d8ee14
Gerrit-Change-Number: 20724
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 29 Nov 2023 18:38:01 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11157: Build native Hadoop libraries for aarch64
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Laszlo Gaal,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20724
to look at the new patch set (#2).
Change subject: IMPALA-11157: Build native Hadoop libraries for aarch64
......................................................................
IMPALA-11157: Build native Hadoop libraries for aarch64
Builds native Hadoop libraries for aarch64 for use as client libraries
in Impala. CDP builds on aarch64 are not yet available; this allows us
to build and test Impala by swapping in aarch64 versions of native
libraries.
Change-Id: Ib3c5576f7decadc4568d70d5520881a314d8ee14
---
M buildall.sh
A source/hadoop/build.sh
2 files changed, 89 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/24/20724/2
--
To view, visit http://gerrit.cloudera.org:8080/20724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib3c5576f7decadc4568d70d5520881a314d8ee14
Gerrit-Change-Number: 20724
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
[native-toolchain-CR] IMPALA-11157: Build native Hadoop libraries for aarch64
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20724 )
Change subject: IMPALA-11157: Build native Hadoop libraries for aarch64
......................................................................
IMPALA-11157: Build native Hadoop libraries for aarch64
Builds native Hadoop libraries for aarch64 for use as client libraries
in Impala. CDP builds on aarch64 are not yet available; this allows us
to build and test Impala by swapping in aarch64 versions of native
libraries.
Change-Id: Ib3c5576f7decadc4568d70d5520881a314d8ee14
Reviewed-on: http://gerrit.cloudera.org:8080/20724
Reviewed-by: Laszlo Gaal <la...@cloudera.com>
Tested-by: Michael Smith <mi...@cloudera.com>
---
M buildall.sh
A source/hadoop/build.sh
2 files changed, 89 insertions(+), 0 deletions(-)
Approvals:
Laszlo Gaal: Looks good to me, approved
Michael Smith: Verified
--
To view, visit http://gerrit.cloudera.org:8080/20724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3c5576f7decadc4568d70d5520881a314d8ee14
Gerrit-Change-Number: 20724
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] IMPALA-11157: Build native Hadoop libraries for aarch64
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/20724 )
Change subject: IMPALA-11157: Build native Hadoop libraries for aarch64
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3c5576f7decadc4568d70d5520881a314d8ee14
Gerrit-Change-Number: 20724
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Nov 2023 14:09:45 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11157: Build native Hadoop libraries for aarch64
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/20724 )
Change subject: IMPALA-11157: Build native Hadoop libraries for aarch64
......................................................................
Patch Set 1:
(1 comment)
I took the liberty of using this patch to test the c7g-based toolchain builder and I found something interesting.
http://gerrit.cloudera.org:8080/#/c/20724/1/source/hadoop/build.sh
File source/hadoop/build.sh:
http://gerrit.cloudera.org:8080/#/c/20724/1/source/hadoop/build.sh@47
PS1, Line 47: mvn
Add --batch-mode here to remove Maven's download progress bar from the build log
--
To view, visit http://gerrit.cloudera.org:8080/20724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3c5576f7decadc4568d70d5520881a314d8ee14
Gerrit-Change-Number: 20724
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Nov 2023 19:53:18 +0000
Gerrit-HasComments: Yes