[jira] Commented: (DERBY-3149) Add ant targets for building and running the package private tests against the classes directories

["Dag H. Wanvik (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542205 ] 

Dag H. Wanvik commented on DERBY-3149:
--------------------------------------

I looked at the patch, it works for me! Thanks, Kristian.

One small note; I would omit the echo in the task :

   java/testing/org/apache/derby/build.xml#pptesting-build

since silence is the default elsewhere. 

Making "debug" always true makes sense here,
but is there a compelling reason to not use the prevailing pattern
of expanding ${debug}? If sounds equally reasonable for all testing code?

+1




> Add ant targets for building and running the package private tests against the classes directories
> --------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3149
>                 URL: https://issues.apache.org/jira/browse/DERBY-3149
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Build tools, Test
>    Affects Versions: 10.4.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>            Priority: Minor
>             Fix For: 10.4.0.0
>
>         Attachments: derby-3149-1a.diff, derby-3149-1a.stat, derby-3149-1b.diff, derby-3149-2a-conditional_compilation_fix.diff
>
>
> Create ant targets in build.xml to compile and run the package private tests.
> The first step will be to run the tests against the classes directories. Implementing a solution that runs against jars is not technically difficult, it just brings a host of decisions to be taken... Maybe even more important, does running against the jars add any value?
> The compile will be included in the 'all' target to test the implementation. Feel free to post your concerns if you think building the package private tests should be a manual action only.
> The tests will also be run as part of junit-all / junitreport.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.