You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/13 08:12:08 UTC
[GitHub] [spark] mgaido91 commented on issue #25137: [SPARK-28348][SQL]
Decimal precision promotion for binary arithmetic with casted decimal type
mgaido91 commented on issue #25137: [SPARK-28348][SQL] Decimal precision promotion for binary arithmetic with casted decimal type
URL: https://github.com/apache/spark/pull/25137#issuecomment-511101099
cc @cloud-fan @JoshRosen what do you think about this PR? This allows users to define as they prefer the result of a decimal operation basically. So they can either rely on our rules or they can choose the precision and scale for the result. Do you see some cases when this might be not good?
anyway I think we should add a note in the migration guide, as it can cause change in the result.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org