You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "Zhengcy05 (via GitHub)" <gi...@apache.org> on 2026/07/28 02:49:49 UTC
[PR] fix: read registry network config from local configuration [incubator-seata]
Zhengcy05 opened a new pull request, #8187:
URL: https://github.com/apache/incubator-seata/pull/8187
- [x] I have read the [CONTRIBUTING.md](https://github.com/apache/incubator-seata/blob/2.x/CONTRIBUTING.md) guidelines.
- [ ] I have registered the PR [changes](https://github.com/apache/incubator-seata/tree/2.x/changes).
### Ⅰ. Describe what this PR did
This PR fixes the server-side registry network configuration lookup for `registry.preferredNetworks` and `registry.ignoredInterfaces`.
Previously, `Server` read these options through `ConfigurationFactory.getInstance()`. When `seata.config.type=nacos` is configured, that instance points to the config center, so local Spring Boot configuration such as `seata.registry.preferred-networks` and `seata.registry.ignored-interfaces` in `application.yml` may be ignored.
This PR changes the lookup to:
- read from `ConfigurationFactory.CURRENT_FILE_INSTANCE` first, which is consistent with other registry-local configuration lookup paths
- fallback to `ConfigurationFactory.getInstance()` when the local registry configuration does not provide the value
- add `ignoredInterfaces` to `RegistryProperties`
- add regression coverage for the local-first lookup behavior
### Ⅱ. Does this pull request fix one issue?
fixes #8182
### Ⅲ. Why don't you add test cases (unit test/integration test)?
Added test cases.
### Ⅳ. Describe how to verify it
- `mvn -pl server -am -Dtest=org.apache.seata.server.ServerConfigTest -DfailIfNoTests=false test`
- `mvn -pl spring/seata-spring-autoconfigure/seata-spring-autoconfigure-core -am -Dtest=org.apache.seata.spring.boot.autoconfigure.properties.registry.RegistryPropertiesTest -DfailIfNoTests=false test`
### Ⅴ. Special notes for reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix: read registry network config from local configuration [incubator-seata]
Posted by "xuxiaowei-com-cn (via GitHub)" <gi...@apache.org>.
xuxiaowei-com-cn commented on PR #8187:
URL: https://github.com/apache/incubator-seata/pull/8187#issuecomment-5099549848
Please complete the [changes](https://github.com/apache/incubator-seata/tree/2.x/changes) above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix: read registry network config from local configuration [incubator-seata]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #8187:
URL: https://github.com/apache/incubator-seata/pull/8187#issuecomment-5099435246
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/8187?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 72.99%. Comparing base ([`2376244`](https://app.codecov.io/gh/apache/incubator-seata/commit/2376244d908042afc90a60e46e903051616f0364?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5e3a402`](https://app.codecov.io/gh/apache/incubator-seata/commit/5e3a4029b8a62ebfd0e65284e26e533089ff27cf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on 2.x.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 2.x #8187 +/- ##
============================================
- Coverage 72.99% 72.99% -0.01%
+ Complexity 1142 1141 -1
============================================
Files 1151 1151
Lines 42272 42275 +3
Branches 5045 5045
============================================
+ Hits 30858 30859 +1
Misses 8935 8935
- Partials 2479 2481 +2
```
| [Files with missing lines](https://app.codecov.io/gh/apache/incubator-seata/pull/8187?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...figure/properties/registry/RegistryProperties.java](https://app.codecov.io/gh/apache/incubator-seata/pull/8187?src=pr&el=tree&filepath=spring%2Fseata-spring-autoconfigure%2Fseata-spring-autoconfigure-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fspring%2Fboot%2Fautoconfigure%2Fproperties%2Fregistry%2FRegistryProperties.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3ByaW5nL3NlYXRhLXNwcmluZy1hdXRvY29uZmlndXJlL3NlYXRhLXNwcmluZy1hdXRvY29uZmlndXJlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlYXRhL3NwcmluZy9ib290L2F1dG9jb25maWd1cmUvcHJvcGVydGllcy9yZWdpc3RyeS9SZWdpc3RyeVByb3BlcnRpZXMuamF2YQ==) | `100.00% <100.00%> (ø)` | |
... and [4 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/8187/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
[](https://app.codecov.io/gh/apache/incubator-seata/pull/8187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix: read registry network config from local configuration [incubator-seata]
Posted by "xuxiaowei-com-cn (via GitHub)" <gi...@apache.org>.
xuxiaowei-com-cn commented on PR #8187:
URL: https://github.com/apache/incubator-seata/pull/8187#issuecomment-5101255011
> > Please complete the [changes](https://github.com/apache/incubator-seata/tree/2.x/changes) above.
>
> Done. By the way, I always fill in the changes before merging. I'm not sure if following my process for subsequent PR contributions will affect you. When is the best time for me to fill out the changes?
Personally, I think we should update the [changes](https://github.com/apache/incubator-seata/tree/2.x/changes) right after the PR is created, so as to save communication costs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix: read registry network config from local configuration [incubator-seata]
Posted by "Zhengcy05 (via GitHub)" <gi...@apache.org>.
Zhengcy05 commented on PR #8187:
URL: https://github.com/apache/incubator-seata/pull/8187#issuecomment-5101055615
> Please complete the [changes](https://github.com/apache/incubator-seata/tree/2.x/changes) above.
Done. By the way, I always fill in the changes before merging. I'm not sure if following my process for subsequent PR contributions will affect you. When is the best time for me to fill out the changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] bugfix: fix read registry network config from local configuration [incubator-seata]
Posted by "xuxiaowei-com-cn (via GitHub)" <gi...@apache.org>.
xuxiaowei-com-cn merged PR #8187:
URL: https://github.com/apache/incubator-seata/pull/8187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org