You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Aleksandr Kovalenko <ak...@hortonworks.com> on 2014/12/03 19:54:17 UTC

Review Request 28659: Alerts UI: Alert Definition details page has multiple issues

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28659/
-----------------------------------------------------------

Review request for Ambari and Srimanth Gunturi.


Bugs: AMBARI-8534
    https://issues.apache.org/jira/browse/AMBARI-8534


Repository: ambari


Description
-------

Various style issues should be fixed.


Diffs
-----

  ambari-web/app/assets/data/alerts/alert_instances_history.json PRE-CREATION 
  ambari-web/app/controllers/main/alerts/definition_details_controller.js e0f4d63 
  ambari-web/app/messages.js daa0d96 
  ambari-web/app/models/alert_definition.js 6f0702c 
  ambari-web/app/styles/alerts.less fdb2cf8 
  ambari-web/app/templates/main/alerts/definition_details.hbs 535c620 
  ambari-web/app/utils/ajax/ajax.js 38093c6 
  ambari-web/app/views/main/alerts/definition_details_view.js 0e88d21 
  ambari-web/test/controllers/main/alerts/definitions_details_controller_test.js 52b3bfa 
  ambari-web/test/models/alert_definition_test.js 9dea494 

Diff: https://reviews.apache.org/r/28659/diff/


Testing
-------

5018 tests complete (7 seconds)
60 tests pending


Thanks,

Aleksandr Kovalenko


Re: Review Request 28659: Alerts UI: Alert Definition details page has multiple issues

Posted by Srimanth Gunturi <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28659/#review63704
-----------------------------------------------------------

Ship it!


Ship It!

- Srimanth Gunturi


On Dec. 3, 2014, 6:54 p.m., Aleksandr Kovalenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28659/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2014, 6:54 p.m.)
> 
> 
> Review request for Ambari and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-8534
>     https://issues.apache.org/jira/browse/AMBARI-8534
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Various style issues should be fixed.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/assets/data/alerts/alert_instances_history.json PRE-CREATION 
>   ambari-web/app/controllers/main/alerts/definition_details_controller.js e0f4d63 
>   ambari-web/app/messages.js daa0d96 
>   ambari-web/app/models/alert_definition.js 6f0702c 
>   ambari-web/app/styles/alerts.less fdb2cf8 
>   ambari-web/app/templates/main/alerts/definition_details.hbs 535c620 
>   ambari-web/app/utils/ajax/ajax.js 38093c6 
>   ambari-web/app/views/main/alerts/definition_details_view.js 0e88d21 
>   ambari-web/test/controllers/main/alerts/definitions_details_controller_test.js 52b3bfa 
>   ambari-web/test/models/alert_definition_test.js 9dea494 
> 
> Diff: https://reviews.apache.org/r/28659/diff/
> 
> 
> Testing
> -------
> 
> 5018 tests complete (7 seconds)
> 60 tests pending
> 
> 
> Thanks,
> 
> Aleksandr Kovalenko
> 
>