[GitHub] [geode] gesterzhou opened pull request #3427: GEODE-6518: when user explicitly specified some PartitionAttributes, …

["gesterzhou (GitHub)" <gi...@apache.org>]

…such as

redundency=1, the PartitionAttributes will not be null, but LocalMaxMemory
could be null if the region is not accessor.

Co-authored-by: Xiaojian Zhou <gz...@pivotal.io>
Co-authored-by: Benjamin Ross <br...@pivotal.io>

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/3427 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jchen21 commented on pull request #3427: GEODE-6518: when user explicitly specified some PartitionAttributes, …

["jchen21 (GitHub)" <gi...@apache.org>]

w/ @BenjaminPerryRoss 
Is it possible that for an accessor, `getLocalMaxMemory()` returns `null`?
e.g. if a partitioned region *without* redundancy, the accessor calls `getLocalMaxMemory()`, it could return `null`? Then it would be mis-identified as a data store.

[ Full content available at: https://github.com/apache/geode/pull/3427 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] gesterzhou commented on pull request #3427: GEODE-6518: when user explicitly specified some PartitionAttributes, …

["gesterzhou (GitHub)" <gi...@apache.org>]

It's just name. It can be any name. But I will change to server3. 

[ Full content available at: https://github.com/apache/geode/pull/3427 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] gesterzhou closed pull request #3427: GEODE-6518: when user explicitly specified some PartitionAttributes, …

["gesterzhou (GitHub)" <gi...@apache.org>]

[ pull request closed by gesterzhou ]

[ Full content available at: https://github.com/apache/geode/pull/3427 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jchen21 commented on pull request #3427: GEODE-6518: when user explicitly specified some PartitionAttributes, …

["jchen21 (GitHub)" <gi...@apache.org>]

w/ @BenjaminPerryRoss 
Isn't it `server3`? Because in line 335, the first parameter of server index is `3`.

[ Full content available at: https://github.com/apache/geode/pull/3427 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] gesterzhou commented on pull request #3427: GEODE-6518: when user explicitly specified some PartitionAttributes, …

["gesterzhou (GitHub)" <gi...@apache.org>]

it will not be null. 

There's code:
      case "PARTITION_PROXY": {
        regionAttributes.setDataPolicy(RegionAttributesDataPolicy.PARTITION);
        regionAttributes.setLocalMaxMemory("0");
        break;
      }


[ Full content available at: https://github.com/apache/geode/pull/3427 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org