[GitHub] [iceberg] rdblue commented on a diff in pull request #6609: Core: Add test for token expiration during refresh

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #6609:
URL: https://github.com/apache/iceberg/pull/6609#discussion_r1072951550


##########
core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java:
##########
@@ -350,6 +350,7 @@ static Long expiresAtMillis(String token) {
 
   /** Class to handle authorization headers and token refresh. */
   public static class AuthSession {
+    private static int tokenRefreshNumRetries = 5;

Review Comment:
   Can we use a constant name so people don't try to set it? `REFRESH_NUM_RETRIES` seems more appropriate.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org