You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2014/01/09 02:24:42 UTC
Re: Review Request 16625: Created cgroups::detached() to wait for all
attached subsystems to be detached.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16625/
-----------------------------------------------------------
(Updated Jan. 9, 2014, 1:24 a.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Changes
-------
Rework.
Summary (updated)
-----------------
Created cgroups::detached() to wait for all attached subsystems to be detached.
Bugs: MESOS-891
https://issues.apache.org/jira/browse/MESOS-891
Repository: mesos-git
Description (updated)
-------
- Not all subsystems are immediately detached after cgroups::cleanup() exits.
- Cgroups-related test cases now wait for detached() after calling cgroups::cleanup() in *TearDown().
- cgroups::detached() is a separate function instead of being embedded in cgroups::cleanup() because cgroups::cleanup() does not always detach all subsystems.
- "a single subsystem can be attached to two hierarchies if both of those hierarchies have only that subsystem attached.": https://access.redhat.com/site/documentation/en-US/Red_Hat_Enterprise_Linux/6/html/Resource_Management_Guide/sec-Relationships_Between_Subsystems_Hierarchies_Control_Groups_and_Tasks.html
Diffs (updated)
-----
src/linux/cgroups.hpp cefa476cffb7de50925387a83526ef2f84d7d69c
src/linux/cgroups.cpp 19ab1f348191ab0315271477b206aa8c6456fd5a
src/tests/cgroups_tests.cpp 0e9316d6561a1339bd2a3fb3482277658beba12b
src/tests/mesos.cpp 5359394f45475803e05d281710139e8cbe7c7364
Diff: https://reviews.apache.org/r/16625/diff/
Testing (updated)
-------
make check
./bin/mesos-tests.sh -j --gtest_filter=SlaveRecoveryTest/1.SchedulerFailover --gtest_repeat=1000
Thanks,
Jiang Yan Xu
Re: Review Request 16625: Created cgroups::detached() to wait for all
attached subsystems to be detached.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16625/#review41937
-----------------------------------------------------------
Can you rebase this because we've changed from CgroupsIsolator to MesosContainerizer?
Once rebased, ContainerizerTest has a hashset of subsystems so you can wait on just those subsystems.
Or, even better, now that cgroup subsystems are mounted separately is it possible to *always* wait until the subsystem is detached during cleanup() and not just in tests?
src/linux/cgroups.hpp
<https://reviews.apache.org/r/16625/#comment75593>
no need to make this const?
- Ian Downes
On April 2, 2014, 10:53 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16625/
> -----------------------------------------------------------
>
> (Updated April 2, 2014, 10:53 a.m.)
>
>
> Review request for mesos and Ian Downes.
>
>
> Bugs: MESOS-891
> https://issues.apache.org/jira/browse/MESOS-891
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> - Not all subsystems are immediately detached after cgroups::cleanup() exits.
> - Cgroups-related test cases now wait for detached() after calling cgroups::cleanup() in *TearDown().
> - cgroups::detached() is a separate function instead of being embedded in cgroups::cleanup() because cgroups::cleanup() does not always detach all subsystems.
> - "a single subsystem can be attached to two hierarchies if both of those hierarchies have only that subsystem attached.": https://access.redhat.com/site/documentation/en-US/Red_Hat_Enterprise_Linux/6/html/Resource_Management_Guide/sec-Relationships_Between_Subsystems_Hierarchies_Control_Groups_and_Tasks.html
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp cefa476cffb7de50925387a83526ef2f84d7d69c
> src/linux/cgroups.cpp 19ab1f348191ab0315271477b206aa8c6456fd5a
> src/tests/cgroups_tests.cpp 0e9316d6561a1339bd2a3fb3482277658beba12b
> src/tests/mesos.cpp 5359394f45475803e05d281710139e8cbe7c7364
>
> Diff: https://reviews.apache.org/r/16625/diff/
>
>
> Testing
> -------
>
> make check
> ./bin/mesos-tests.sh -j --gtest_filter=SlaveRecoveryTest/1.SchedulerFailover --gtest_repeat=1000
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 16625: Created cgroups::detached() to wait for all
attached subsystems to be detached.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16625/#review39345
-----------------------------------------------------------
Bad patch!
Reviews applied: [16625]
Failed command: git apply --index 16625.patch
Error:
error: patch failed: src/linux/cgroups.cpp:1815
error: src/linux/cgroups.cpp: patch does not apply
error: patch failed: src/tests/cgroups_tests.cpp:154
error: src/tests/cgroups_tests.cpp: patch does not apply
error: patch failed: src/tests/mesos.cpp:249
error: src/tests/mesos.cpp: patch does not apply
- Mesos ReviewBot
On April 2, 2014, 5:53 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16625/
> -----------------------------------------------------------
>
> (Updated April 2, 2014, 5:53 p.m.)
>
>
> Review request for mesos and Ian Downes.
>
>
> Bugs: MESOS-891
> https://issues.apache.org/jira/browse/MESOS-891
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> - Not all subsystems are immediately detached after cgroups::cleanup() exits.
> - Cgroups-related test cases now wait for detached() after calling cgroups::cleanup() in *TearDown().
> - cgroups::detached() is a separate function instead of being embedded in cgroups::cleanup() because cgroups::cleanup() does not always detach all subsystems.
> - "a single subsystem can be attached to two hierarchies if both of those hierarchies have only that subsystem attached.": https://access.redhat.com/site/documentation/en-US/Red_Hat_Enterprise_Linux/6/html/Resource_Management_Guide/sec-Relationships_Between_Subsystems_Hierarchies_Control_Groups_and_Tasks.html
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp cefa476cffb7de50925387a83526ef2f84d7d69c
> src/linux/cgroups.cpp 19ab1f348191ab0315271477b206aa8c6456fd5a
> src/tests/cgroups_tests.cpp 0e9316d6561a1339bd2a3fb3482277658beba12b
> src/tests/mesos.cpp 5359394f45475803e05d281710139e8cbe7c7364
>
> Diff: https://reviews.apache.org/r/16625/diff/
>
>
> Testing
> -------
>
> make check
> ./bin/mesos-tests.sh -j --gtest_filter=SlaveRecoveryTest/1.SchedulerFailover --gtest_repeat=1000
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 16625: Created cgroups::detached() to wait for all
attached subsystems to be detached.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16625/
-----------------------------------------------------------
(Updated April 2, 2014, 5:53 p.m.)
Review request for mesos and Ian Downes.
Changes
-------
Assigning to Ian to shepherd -- Vinod.
Bugs: MESOS-891
https://issues.apache.org/jira/browse/MESOS-891
Repository: mesos-git
Description
-------
- Not all subsystems are immediately detached after cgroups::cleanup() exits.
- Cgroups-related test cases now wait for detached() after calling cgroups::cleanup() in *TearDown().
- cgroups::detached() is a separate function instead of being embedded in cgroups::cleanup() because cgroups::cleanup() does not always detach all subsystems.
- "a single subsystem can be attached to two hierarchies if both of those hierarchies have only that subsystem attached.": https://access.redhat.com/site/documentation/en-US/Red_Hat_Enterprise_Linux/6/html/Resource_Management_Guide/sec-Relationships_Between_Subsystems_Hierarchies_Control_Groups_and_Tasks.html
Diffs
-----
src/linux/cgroups.hpp cefa476cffb7de50925387a83526ef2f84d7d69c
src/linux/cgroups.cpp 19ab1f348191ab0315271477b206aa8c6456fd5a
src/tests/cgroups_tests.cpp 0e9316d6561a1339bd2a3fb3482277658beba12b
src/tests/mesos.cpp 5359394f45475803e05d281710139e8cbe7c7364
Diff: https://reviews.apache.org/r/16625/diff/
Testing
-------
make check
./bin/mesos-tests.sh -j --gtest_filter=SlaveRecoveryTest/1.SchedulerFailover --gtest_repeat=1000
Thanks,
Jiang Yan Xu