Re: [PR] Fix flaky pauseless ingestion integration tests [pinot]

["xiangfu0 (via GitHub)" <gi...@apache.org>]

xiangfu0 commented on PR #19133:
URL: https://github.com/apache/pinot/pull/19133#issuecomment-5161259999

   Addressed the suppressed review comment on `BasePauselessRealtimeIngestionTest`: `injectFailure()` and `disableFailure()` now return early when `getFailurePoint()` is null, so no null key is put into the failure-config map and `_failureEnabled` no longer flips to true for tests that inject no failure (`TableRebalancePauselessIntegrationTest`). No behavior change today — that class's `getCountStarResultWithFailure()` already returns `DEFAULT_COUNT_STAR_RESULT` — but it removes the latent trap for future subclasses. Verified with `TableRebalancePauselessIntegrationTest`, `PauselessRealtimeIngestionIntegrationTest`, and the three controller-failure tests (6 tests, 0 failures on JDK 25).
   
   _🤖 Addressed by [Claude Code](https://claude.com/claude-code)_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org