You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/05/12 06:49:18 UTC

[GitHub] [shardingsphere] huntkalio opened a new issue #10314: shardingsphere-scaling transfer -1 to 255 for TINYINT when IN 'EXECUTE_INCREMENTAL_TASK'

huntkalio opened a new issue #10314:
URL: https://github.com/apache/shardingsphere/issues/10314


   ## Bug Report
   1.I use the master version of  shardingsphere-scaling to test database scaling.I have a table which has a column like this:
   `client_type` TINYINT(2) NULL DEFAULT '-1';
   
   2.when running shardingsphere-scaling transfer '-1'  value to '255' value.Then the sql will transfer like this:
   insert into test(id,client_type) values(1,255)......;
   
   3.I found that MySQLTinyBinlogProtocolValue.java use MySQLPacketPayload   readInt1() to read the value,but MySQLPacketPayload use ‘readUnsignedByte()’  to read value.
   
   4.MySQLShortBinlogProtocolValue and other may have the same problem.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tristaZero commented on issue #10314: shardingsphere-scaling transfer -1 to 255 for TINYINT when IN 'EXECUTE_INCREMENTAL_TASK'

Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #10314:
URL: https://github.com/apache/shardingsphere/issues/10314#issuecomment-842040496


   @huntkalio Similar.
   
   Actually, I have no idea how and why we fix #5868. Maybe the assignee of that issue can give us some hints. @tuohai666 
   
   Besides, I still confused by @huntkalio described in this  issue, 
   > I found that MySQLTinyBinlogProtocolValue.java use MySQLPacketPayload readInt1() to read the value,but MySQLPacketPayload use ‘readUnsignedByte()’ to read value.
   
   Maybe we start by figuring this part out. @RaigorJiang  Like @huntkalio 's comment, it looks like `table metadata` is required.
   
   @huntkalio This issue just impacts sharding-scaling, doesn't it? @avalon5666 If available, could you give it a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tristaZero commented on issue #10314: shardingsphere-scaling transfer -1 to 255 for TINYINT when IN 'EXECUTE_INCREMENTAL_TASK'

Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #10314:
URL: https://github.com/apache/shardingsphere/issues/10314#issuecomment-842040496


   @huntkalio Similar.
   
   Actually, I have no idea how and why we fix #5868. Maybe the assignee of that issue can give us some hints. @tuohai666 
   
   Besides, I still confused by @huntkalio described in this  issue, 
   > I found that MySQLTinyBinlogProtocolValue.java use MySQLPacketPayload readInt1() to read the value,but MySQLPacketPayload use ‘readUnsignedByte()’ to read value.
   
   Maybe we start by figuring this part out. @RaigorJiang  Like @huntkalio 's comment, it looks like `table metadata` is required.
   
   @huntkalio This issue just impacts sharding-scaling, doesn't it? @avalon5666 If available, could you give it a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tristaZero commented on issue #10314: shardingsphere-scaling transfer -1 to 255 for TINYINT when IN 'EXECUTE_INCREMENTAL_TASK'

Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #10314:
URL: https://github.com/apache/shardingsphere/issues/10314#issuecomment-840454951


   Hi @huntkalio ,
   Thanks for your report and debug. So we mainly locate this issue is about `MySQL protocol, right?
   @TeslaCN could you give this one a double-checking? 
   @RaigorJiang Do you have any idea dealing with this one?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] huntkalio commented on issue #10314: shardingsphere-scaling transfer -1 to 255 for TINYINT when IN 'EXECUTE_INCREMENTAL_TASK'

Posted by GitBox <gi...@apache.org>.
huntkalio commented on issue #10314:
URL: https://github.com/apache/shardingsphere/issues/10314#issuecomment-843710667


   @tristaZero  I only test sharding-scaling and found this problem。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] RaigorJiang commented on issue #10314: shardingsphere-scaling transfer -1 to 255 for TINYINT when IN 'EXECUTE_INCREMENTAL_TASK'

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #10314:
URL: https://github.com/apache/shardingsphere/issues/10314#issuecomment-840474874


   I have a question, why we changed it to unsigned in 5868?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] avalon5666 commented on issue #10314: shardingsphere-scaling transfer -1 to 255 for TINYINT when IN 'EXECUTE_INCREMENTAL_TASK'

Posted by GitBox <gi...@apache.org>.
avalon5666 commented on issue #10314:
URL: https://github.com/apache/shardingsphere/issues/10314#issuecomment-842121415


   I will check this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] huntkalio commented on issue #10314: shardingsphere-scaling transfer -1 to 255 for TINYINT when IN 'EXECUTE_INCREMENTAL_TASK'

Posted by GitBox <gi...@apache.org>.
huntkalio commented on issue #10314:
URL: https://github.com/apache/shardingsphere/issues/10314#issuecomment-840495391


   yes,may add something like this:
   
   https://github.com/alibaba/canal/blob/master/parse/src/main/java/com/alibaba/otter/canal/parse/inbound/TableMeta.java


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tristaZero closed issue #10314: shardingsphere-scaling transfer -1 to 255 for TINYINT when IN 'EXECUTE_INCREMENTAL_TASK'

Posted by GitBox <gi...@apache.org>.
tristaZero closed issue #10314:
URL: https://github.com/apache/shardingsphere/issues/10314


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] avalon5666 commented on issue #10314: shardingsphere-scaling transfer -1 to 255 for TINYINT when IN 'EXECUTE_INCREMENTAL_TASK'

Posted by GitBox <gi...@apache.org>.
avalon5666 commented on issue #10314:
URL: https://github.com/apache/shardingsphere/issues/10314#issuecomment-842121415


   I will check this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] RaigorJiang commented on issue #10314: shardingsphere-scaling transfer -1 to 255 for TINYINT when IN 'EXECUTE_INCREMENTAL_TASK'

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #10314:
URL: https://github.com/apache/shardingsphere/issues/10314#issuecomment-839531222


   ref to #5868
   This issue may needs some discussion  @tristaZero 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] huntkalio commented on issue #10314: shardingsphere-scaling transfer -1 to 255 for TINYINT when IN 'EXECUTE_INCREMENTAL_TASK'

Posted by GitBox <gi...@apache.org>.
huntkalio commented on issue #10314:
URL: https://github.com/apache/shardingsphere/issues/10314#issuecomment-840490227


   @tristaZero ,I think we can't distinguish whether it is signed or unsigned only by MySQL binlog protocol,may need to use the table meta info.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tristaZero commented on issue #10314: shardingsphere-scaling transfer -1 to 255 for TINYINT when IN 'EXECUTE_INCREMENTAL_TASK'

Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #10314:
URL: https://github.com/apache/shardingsphere/issues/10314#issuecomment-840491714


   Maybe, like [Table Metadata](https://github.com/apache/shardingsphere/blob/master/shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/metadata/schema/model/TableMetaData.java)?
   
   @tristaZero 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org