You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/09/02 11:07:00 UTC
[jira] [Commented] (IMPALA-11257) Fix CMake warnings for module names and cmake_minimum_required
[ https://issues.apache.org/jira/browse/IMPALA-11257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599421#comment-17599421 ]
ASF subversion and git services commented on IMPALA-11257:
----------------------------------------------------------
Commit d74d6994cc25ed2090886d6b406cf477a6ccf6b4 in impala's branch refs/heads/master from Peter Rozsa
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=d74d6994c ]
IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
This patch renames the Exec libraries to distinguish them from
external libraries like avro, kudu_client and orc
Due to IMPALA-11257, the cmake_minimum_required calls are
also removed from the new libraries
Change-Id: I042478e371049a7aed74f43c2bbfcb7900a53dd0
Reviewed-on: http://gerrit.cloudera.org:8080/18910
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> Fix CMake warnings for module names and cmake_minimum_required
> --------------------------------------------------------------
>
> Key: IMPALA-11257
> URL: https://issues.apache.org/jira/browse/IMPALA-11257
> Project: IMPALA
> Issue Type: Task
> Components: Infrastructure
> Affects Versions: Impala 4.1.0
> Reporter: Joe McDonnell
> Assignee: Joe McDonnell
> Priority: Minor
>
> CMake produces warnings during the build. One flavor is complaints about the package names for various cmake_modules. The other flavor is complaining about cmake_minimum_required calls with old versions of CMake.
> {noformat}
> CMake Warning (dev) at /opt/Impala-Toolchain/toolchain-packages-gcc7.5.0/cmake-3.22.2/share/cmake-3.22/Modules/FindPackageHandleStandardArgs.cmake:438 (message):
> The package name passed to `find_package_handle_standard_args` (PROTOBUF)
> does not match the name of the calling package (Protobuf). This can lead
> to problems in calling code that expects `find_package` result variables
> (e.g., `_FOUND`) to follow a certain pattern.
> ...
> CMake Deprecation Warning at common/thrift/CMakeLists.txt:19 (cmake_minimum_required):
> Compatibility with CMake < 2.8.12 will be removed from a future version of
> CMake.{noformat}
> These are ugly and spam the logs. We should fix these.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org