You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2019/04/23 13:47:30 UTC

[GitHub] [maven-checkstyle-plugin] romani commented on a change in pull request #13: MCHECKSTYLE-366 Upgrade checkstyle to a more recent version

romani commented on a change in pull request #13: MCHECKSTYLE-366 Upgrade checkstyle to a more recent version
URL: https://github.com/apache/maven-checkstyle-plugin/pull/13#discussion_r277685474
 
 

 ##########
 File path: src/it/MCHECKSTYLE-137/checkstyle.xml
 ##########
 @@ -20,8 +20,6 @@ under the License.
 <!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.2//EN" "http://www.puppycrawl.com/dtds/configuration_1_2.dtd">
 
 Review comment:
   it would be good if you can update all xmls to have new DOCTYPE that reference to secure website.
   Example: https://github.com/checkstyle/checkstyle/blob/master/config/checkstyle_checks.xml#L2
   There should be no `Puppy Crawl`, no `http://`.
   
   it is part of security issue - https://github.com/checkstyle/checkstyle/issues/6478  and https://github.com/checkstyle/checkstyle/issues/6474

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services