You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/09/08 06:58:01 UTC

[GitHub] [iotdb] HTHou commented on a diff in pull request #7187: [IOTDB-4270] Support parallel transport for each pipe

HTHou commented on code in PR #7187:
URL: https://github.com/apache/iotdb/pull/7187#discussion_r965574540


##########
server/src/main/java/org/apache/iotdb/db/sync/transport/client/IoTDBSyncClient.java:
##########
@@ -78,12 +80,14 @@ public class IoTDBSyncClient implements ISyncClient {
    * @param port remote port
    * @param localIP local ip address
    */
-  public IoTDBSyncClient(Pipe pipe, String ipAddress, int port, String localIP) {
+  public IoTDBSyncClient(
+      Pipe pipe, String ipAddress, int port, String localIP, String storageGroupName) {

Review Comment:
   IpAddress -> remoteAddress, localIP -> localAddress
   Update javadoc @param storageGroupName



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org