You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/11/08 15:41:45 UTC
[GitHub] [cloudstack] GutoVeronezi opened a new pull request, #6877: Fix typos and improve javadocs
GutoVeronezi opened a new pull request, #6877:
URL: https://github.com/apache/cloudstack/pull/6877
### Description
PR #5909 introduced a class to convert bytes through the scales (B, KiB, KB, MiB, MB...); however, there are some typos in the javadocs and method names. This PR intends to fix those typos and improve the javadocs.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6877: Fix typos and improve javadocs on ByteScaleUtils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6877:
URL: https://github.com/apache/cloudstack/pull/6877#issuecomment-1308754400
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6877: Fix typos and improve javadocs on ByteScaleUtils
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on code in PR #6877:
URL: https://github.com/apache/cloudstack/pull/6877#discussion_r1016986509
##########
utils/src/main/java/org/apache/cloudstack/utils/bytescale/ByteScaleUtils.java:
##########
@@ -27,32 +27,32 @@ public class ByteScaleUtils {
private ByteScaleUtils() {}
/**
- * Converts mebibytes to bytes.
+ * Converts mebibyte to bytes.
*
* @param mib The value to convert to bytes (eq: 1, 2, 3, ..., 42,...).
- * @return The parameter multiplied by 1048576 (1024 * 1024, 1 MiB).
+ * @return The parameter multiplied by 2²⁰ (1048576 | 1024 * 1024 | 1 MiB | ).
*/
public static long mibToBytes(long mib) {
Review Comment:
@GutoVeronezi
do we need to change this to `miBToBytes` as well ? looks a bit strange
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6877: Fix typos and improve javadocs on ByteScaleUtils
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6877:
URL: https://github.com/apache/cloudstack/pull/6877#issuecomment-1309239697
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6877)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6877&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6877&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6877&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6877&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6877&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6877&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6877&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6877&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6877&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6877&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6877&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6877&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6877&metric=new_coverage&view=list) [81.2% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6877&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6877&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6877&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6877: Fix typos and improve javadocs on ByteScaleUtils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6877:
URL: https://github.com/apache/cloudstack/pull/6877#issuecomment-1308836204
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. LL-JID 232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6877: Fix typos and improve javadocs on ByteScaleUtils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6877:
URL: https://github.com/apache/cloudstack/pull/6877#issuecomment-1309220009
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. LL-JID 237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6877: Fix typos and improve javadocs on ByteScaleUtils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6877:
URL: https://github.com/apache/cloudstack/pull/6877#issuecomment-1309804784
<b>Trillian test result (tid-54)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42489 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6877-t54-kvm-centos7.zip
Smoke tests completed. 102 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 553.92 | test_kubernetes_clusters.py
test_01_redundant_vpc_site2site_vpn | `Failure` | 752.15 | test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options | `Error` | 1274.51 | test_vpc_vpn.py
test_01_vpc_site2site_vpn | `Error` | 545.05 | test_vpc_vpn.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6877: Fix typos and improve javadocs on ByteScaleUtils
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6877:
URL: https://github.com/apache/cloudstack/pull/6877#issuecomment-1309986373
the kubernetes error is intermittent and the vpc_vpn errors are due to a template download failure at the backend; merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6877: Fix typos and improve javadocs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6877:
URL: https://github.com/apache/cloudstack/pull/6877#issuecomment-1307485247
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. LL-JID 225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #6877: Fix typos and improve javadocs on ByteScaleUtils
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6877:
URL: https://github.com/apache/cloudstack/pull/6877#issuecomment-1307607496
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6877?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6877](https://codecov.io/gh/apache/cloudstack/pull/6877?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (39f8f31) into [main](https://codecov.io/gh/apache/cloudstack/commit/4c5a2ba3a6eb6399390c2f8963cb26e0e35fc058?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4c5a2ba) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## main #6877 +/- ##
============================================
- Coverage 10.84% 10.84% -0.01%
+ Complexity 7105 7103 -2
============================================
Files 2485 2485
Lines 245417 245417
Branches 38326 38326
============================================
- Hits 26622 26618 -4
- Misses 215526 215531 +5
+ Partials 3269 3268 -1
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6877?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tionrule/presetvariables/PresetVariableHelper.java](https://codecov.io/gh/apache/cloudstack/pull/6877/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZnJhbWV3b3JrL3F1b3RhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3F1b3RhL2FjdGl2YXRpb25ydWxlL3ByZXNldHZhcmlhYmxlcy9QcmVzZXRWYXJpYWJsZUhlbHBlci5qYXZh) | `98.56% <100.00%> (ø)` | |
| [...ervisor/kvm/resource/LibvirtComputingResource.java](https://codecov.io/gh/apache/cloudstack/pull/6877/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2UvTGlidmlydENvbXB1dGluZ1Jlc291cmNlLmphdmE=) | `15.69% <100.00%> (ø)` | |
| [...resource/wrapper/LibvirtScaleVmCommandWrapper.java](https://codecov.io/gh/apache/cloudstack/pull/6877/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2Uvd3JhcHBlci9MaWJ2aXJ0U2NhbGVWbUNvbW1hbmRXcmFwcGVyLmphdmE=) | `94.11% <100.00%> (ø)` | |
| [...dstack/network/contrail/model/ModelObjectBase.java](https://codecov.io/gh/apache/cloudstack/pull/6877/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9uZXR3b3JrLWVsZW1lbnRzL2p1bmlwZXItY29udHJhaWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svbmV0d29yay9jb250cmFpbC9tb2RlbC9Nb2RlbE9iamVjdEJhc2UuamF2YQ==) | `21.15% <0.00%> (-7.70%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6877: Fix typos and improve javadocs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6877:
URL: https://github.com/apache/cloudstack/pull/6877#issuecomment-1307423470
@GutoVeronezi a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #6877: Fix typos and improve javadocs
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on PR #6877:
URL: https://github.com/apache/cloudstack/pull/6877#issuecomment-1307422005
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6877: Fix typos and improve javadocs on ByteScaleUtils
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6877:
URL: https://github.com/apache/cloudstack/pull/6877#issuecomment-1309180433
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on a diff in pull request #6877: Fix typos and improve javadocs on ByteScaleUtils
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on code in PR #6877:
URL: https://github.com/apache/cloudstack/pull/6877#discussion_r1017004468
##########
utils/src/main/java/org/apache/cloudstack/utils/bytescale/ByteScaleUtils.java:
##########
@@ -27,32 +27,32 @@ public class ByteScaleUtils {
private ByteScaleUtils() {}
/**
- * Converts mebibytes to bytes.
+ * Converts mebibyte to bytes.
*
* @param mib The value to convert to bytes (eq: 1, 2, 3, ..., 42,...).
- * @return The parameter multiplied by 1048576 (1024 * 1024, 1 MiB).
+ * @return The parameter multiplied by 2²⁰ (1048576 | 1024 * 1024 | 1 MiB | ).
*/
public static long mibToBytes(long mib) {
Review Comment:
@weizhouapache, what do you think about not using the symbols (e.g.: `mebibytesToBytes`) ? This way it would leave no doubt and would be consistent, as it is written `...ToBytes`, and not `...toB`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6877: Fix typos and improve javadocs on ByteScaleUtils
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on code in PR #6877:
URL: https://github.com/apache/cloudstack/pull/6877#discussion_r1017028213
##########
utils/src/main/java/org/apache/cloudstack/utils/bytescale/ByteScaleUtils.java:
##########
@@ -27,32 +27,32 @@ public class ByteScaleUtils {
private ByteScaleUtils() {}
/**
- * Converts mebibytes to bytes.
+ * Converts mebibyte to bytes.
*
* @param mib The value to convert to bytes (eq: 1, 2, 3, ..., 42,...).
- * @return The parameter multiplied by 1048576 (1024 * 1024, 1 MiB).
+ * @return The parameter multiplied by 2²⁰ (1048576 | 1024 * 1024 | 1 MiB | ).
*/
public static long mibToBytes(long mib) {
Review Comment:
@GutoVeronezi looks good to me.
@DaanHoogland what is your opinion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6877: Fix typos and improve javadocs on ByteScaleUtils
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #6877:
URL: https://github.com/apache/cloudstack/pull/6877#discussion_r1017935778
##########
utils/src/main/java/org/apache/cloudstack/utils/bytescale/ByteScaleUtils.java:
##########
@@ -27,32 +27,32 @@ public class ByteScaleUtils {
private ByteScaleUtils() {}
/**
- * Converts mebibytes to bytes.
+ * Converts mebibyte to bytes.
*
* @param mib The value to convert to bytes (eq: 1, 2, 3, ..., 42,...).
- * @return The parameter multiplied by 1048576 (1024 * 1024, 1 MiB).
+ * @return The parameter multiplied by 2²⁰ (1048576 | 1024 * 1024 | 1 MiB | ).
*/
public static long mibToBytes(long mib) {
Review Comment:
I like @GutoVeronezi 's last proposal here, reading will actually be quicker as you don´t need to translate in your head.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #6877: Fix typos and improve javadocs on ByteScaleUtils
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged PR #6877:
URL: https://github.com/apache/cloudstack/pull/6877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6877: Fix typos and improve javadocs on ByteScaleUtils
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6877:
URL: https://github.com/apache/cloudstack/pull/6877#issuecomment-1307534103
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6877)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6877&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6877&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6877&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6877&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6877&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6877&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6877&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6877&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6877&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6877&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6877&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6877&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6877&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6877&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6877&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6877&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6877: Fix typos and improve javadocs on ByteScaleUtils
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6877:
URL: https://github.com/apache/cloudstack/pull/6877#issuecomment-1308753739
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6877: Fix typos and improve javadocs on ByteScaleUtils
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on code in PR #6877:
URL: https://github.com/apache/cloudstack/pull/6877#discussion_r1016986917
##########
utils/src/main/java/org/apache/cloudstack/utils/bytescale/ByteScaleUtils.java:
##########
@@ -27,32 +27,32 @@ public class ByteScaleUtils {
private ByteScaleUtils() {}
/**
- * Converts mebibytes to bytes.
+ * Converts mebibyte to bytes.
*
* @param mib The value to convert to bytes (eq: 1, 2, 3, ..., 42,...).
- * @return The parameter multiplied by 1048576 (1024 * 1024, 1 MiB).
+ * @return The parameter multiplied by 2²⁰ (1048576 | 1024 * 1024 | 1 MiB | ).
*/
public static long mibToBytes(long mib) {
Review Comment:
@GutoVeronezi
thanks for fixing btw
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6877: Fix typos and improve javadocs on ByteScaleUtils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6877:
URL: https://github.com/apache/cloudstack/pull/6877#issuecomment-1309096407
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6877: Fix typos and improve javadocs on ByteScaleUtils
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6877:
URL: https://github.com/apache/cloudstack/pull/6877#issuecomment-1309095348
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6877: Fix typos and improve javadocs on ByteScaleUtils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6877:
URL: https://github.com/apache/cloudstack/pull/6877#issuecomment-1309181428
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org