You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Aaron Fabbri (JIRA)" <ji...@apache.org> on 2017/02/20 22:49:44 UTC
[jira] [Updated] (HADOOP-14096) s3guard: regression in
dirListingUnion
[ https://issues.apache.org/jira/browse/HADOOP-14096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron Fabbri updated HADOOP-14096:
----------------------------------
Attachment: HADOOP-14096-HADOOP-13345.001.patch
Attaching a patch. Includes new unit test that fails without the fix, and succeeds with it.
> s3guard: regression in dirListingUnion
> --------------------------------------
>
> Key: HADOOP-14096
> URL: https://issues.apache.org/jira/browse/HADOOP-14096
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: HADOOP-13345
> Reporter: Aaron Fabbri
> Assignee: Aaron Fabbri
> Priority: Critical
> Attachments: HADOOP-14096-HADOOP-13345.001.patch
>
>
> Just noticed HADOOP-14020 introduced a bug in S3Guard#dirListingUnion.
> The offending change is here:
> {noformat}
> - if (dirMeta.get(s.getPath()) == null) {
> - dirMeta.put(s);
> - }
> + changed = changed || dirMeta.put(s);
> + }
> +
> {noformat}
> hint: Logical OR is a short-circuit operator.
> Easy fix, but should probably come with a unit test for dirListingUnion().
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org