[jira] [Commented] (LIBCLOUD-436) Improvements to DigitalOcean compute driver

["Tomaz Muraus (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LIBCLOUD-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13821407#comment-13821407 ] 

Tomaz Muraus commented on LIBCLOUD-436:
---------------------------------------

The main reason the code for DigitalOcean driver looks good compared to some other existing drivers is, that it was added fairly recently.

As such:

- Code is simple
- It contains no legacy code
- It contains no technical debt
- Code style is consistent

Some of the existing drivers were added a long time ago, before we strictly enforced style, tests and documentation rules. As such, they carry a lot of legacy code, technical debt and contain a mixture of different styles.

One of my future goals is to clean existing drivers and remove the ones which are "really bad". Really bad is in this case defined as:

* Cost to maintain the driver is really high. In a lot of cases it would cost a lot less in a long run to simply rewrite the driver.
* The driver doesn't add a lot of value to our users. In some cases they even cause "negative value" when they frustrate our users
* Code is convoluted and hard to maintain

This won't just reduce frustration for our users, but it will allow us to focus our efforts on other things instead of wasting tons of time on keeping some of the really bad drivers "alive".

> Improvements to DigitalOcean compute driver
> -------------------------------------------
>
>                 Key: LIBCLOUD-436
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-436
>             Project: Libcloud
>          Issue Type: Improvement
>          Components: Compute
>            Reporter: Markos Gogoulos
>
> Compute driver for DigitalOcean is one of the greatest drivers of libcloud! Easy to read and understand. The patch contributes the following changes to the driver:
> improves  response messages and node states, 
> allows to specify private networking on create_node,
> returns error message if failed create_node, 
> adds ex_start_node/ex_stop_node, 
> adds price/disk on create_node



--
This message was sent by Atlassian JIRA
(v6.1#6144)