[GitHub] [kylin] Sean-Gu commented on a change in pull request #775: KYLIN-4115 Always load kafkaConsumerProperties

[GitBox <gi...@apache.org>]

Sean-Gu commented on a change in pull request #775: KYLIN-4115 Always  load kafkaConsumerProperties
URL: https://github.com/apache/kylin/pull/775#discussion_r325970232
 
 

 ##########
 File path: source-kafka/src/main/java/org/apache/kylin/source/kafka/util/KafkaClient.java
 ##########
 @@ -57,16 +57,16 @@ public static KafkaConsumer getKafkaConsumer(String brokers, String consumerGrou
 
     private static Properties constructDefaultKafkaConsumerProperties(String brokers, String consumerGroup, Properties properties) {
         Properties props = new Properties();
-        if (properties != null) {
-            for (Map.Entry entry : properties.entrySet()) {
-                props.put(entry.getKey(), entry.getValue());
-            }
-        }
         props.put("bootstrap.servers", brokers);
         props.put("key.deserializer", StringDeserializer.class.getName());
         props.put("value.deserializer", StringDeserializer.class.getName());
         props.put("group.id", consumerGroup);
         props.put("enable.auto.commit", "false");
+        if (properties != null) {
 
 Review comment:
   Maybe in terms of design, for these five properties, we just don't want them to be overridden by .xml or .xml.override.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services