You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by jay vyas <ja...@gmail.com> on 2014/12/18 14:02:15 UTC
[VOTE] Should we allow +1 reviews for bigtop non-commiters with
demonstrated competency?
Hi folks. Please cast a vote on this idea,... Its not a huge deal either
way, so don't be shy :)... Just thought I'd bring up the idea.
I propose : allowing non commiters to +1 patches as sufficient for commit.
Why? To increase the ability of external community members to increase
productivity in the bigtop process.
The proposal: In cases where a developer has proven comptency/expertise in
an area of the code base, or significantly knowledgeable on the subject
matter or patch in question, we allow a +1 as sufficient for commit.
+1 : Its okay for a non-commiter to +1 a commit, and that is sufficient to
push a patch to master.
-1 : Only commiters can give a official +1 which substantiates to commit to
master.
Thanks !
Jay
Re: [VOTE] Should we allow +1 reviews for bigtop non-commiters with demonstrated competency?
Posted by Jay Vyas <ja...@gmail.com>.
Thanks cos, yup, It's a wrap! No change to process.
Summary: the proposed vote to modify the +1 requirements resulted in ...
-1: 4 binding
0: 0
+1: 1 binding
votes. so this idea was **voted down and No change to process... **
1) Thanks for the feedback!
2) I also appreciate the alt. ideas and workarounds that were brought up which was were informed and quite sensible.
Have a very bigtop Xmas!
J
> On Dec 24, 2014, at 7:21 PM, Konstantin Boudnik <co...@apache.org> wrote:
>
> Let's wrap the vote. It's been running for 6 days - seems to be sufficient.
> Jay, will you do it, please?
>
> Cos
>
>> On Thu, Dec 18, 2014 at 08:02AM, jay vyas wrote:
>> Hi folks. Please cast a vote on this idea,... Its not a huge deal either
>> way, so don't be shy :)... Just thought I'd bring up the idea.
>>
>> I propose : allowing non commiters to +1 patches as sufficient for commit.
>>
>> Why? To increase the ability of external community members to increase
>> productivity in the bigtop process.
>>
>> The proposal: In cases where a developer has proven comptency/expertise in
>> an area of the code base, or significantly knowledgeable on the subject
>> matter or patch in question, we allow a +1 as sufficient for commit.
>>
>> +1 : Its okay for a non-commiter to +1 a commit, and that is sufficient to
>> push a patch to master.
>> -1 : Only commiters can give a official +1 which substantiates to commit to
>> master.
>>
>>
>> Thanks !
>>
>> Jay
Re: [VOTE] Should we allow +1 reviews for bigtop non-commiters with
demonstrated competency?
Posted by Konstantin Boudnik <co...@apache.org>.
Let's wrap the vote. It's been running for 6 days - seems to be sufficient.
Jay, will you do it, please?
Cos
On Thu, Dec 18, 2014 at 08:02AM, jay vyas wrote:
> Hi folks. Please cast a vote on this idea,... Its not a huge deal either
> way, so don't be shy :)... Just thought I'd bring up the idea.
>
> I propose : allowing non commiters to +1 patches as sufficient for commit.
>
> Why? To increase the ability of external community members to increase
> productivity in the bigtop process.
>
> The proposal: In cases where a developer has proven comptency/expertise in
> an area of the code base, or significantly knowledgeable on the subject
> matter or patch in question, we allow a +1 as sufficient for commit.
>
> +1 : Its okay for a non-commiter to +1 a commit, and that is sufficient to
> push a patch to master.
> -1 : Only commiters can give a official +1 which substantiates to commit to
> master.
>
>
> Thanks !
>
> Jay
Re: [VOTE] Should we allow +1 reviews for bigtop non-commiters with
demonstrated competency?
Posted by Konstantin Boudnik <co...@apache.org>.
Yup - that's the point I've missed to mention. Thanks for bring this up.
So, let's see them reviews coming, guys!
Cos
On Tue, Dec 23, 2014 at 11:08AM, Roman Shaposhnik wrote:
> On Tue, Dec 23, 2014 at 5:16 AM, Jay Vyas <ja...@gmail.com> wrote:
> > Gotcha, and I think in general , there is some pushback on this idea.
> >
> > I think Bruno and cos comments are logical : since a +1 requires cultural stuff that
> > we can't get from "just anyone" even if they are knowledgable on some specifics....
> >
> > So I'm okay to keep things going the way they are, just wanted some feedback on this .
> >
> > Thanks guys!
>
> Btw, this is not to say that we shouldn't actively encourage and solicit
> +/-1 from non-committers. Its just that they are not binding, but still
> extremely useful way of engaging with the community.
>
> Thanks,
> Roman.
Re: [VOTE] Should we allow +1 reviews for bigtop non-commiters with
demonstrated competency?
Posted by Roman Shaposhnik <ro...@shaposhnik.org>.
On Tue, Dec 23, 2014 at 5:16 AM, Jay Vyas <ja...@gmail.com> wrote:
> Gotcha, and I think in general , there is some pushback on this idea.
>
> I think Bruno and cos comments are logical : since a +1 requires cultural stuff that
> we can't get from "just anyone" even if they are knowledgable on some specifics....
>
> So I'm okay to keep things going the way they are, just wanted some feedback on this .
>
> Thanks guys!
Btw, this is not to say that we shouldn't actively encourage and solicit
+/-1 from non-committers. Its just that they are not binding, but still
extremely useful way of engaging with the community.
Thanks,
Roman.
Re: [VOTE] Should we allow +1 reviews for bigtop non-commiters with demonstrated competency?
Posted by Jay Vyas <ja...@gmail.com>.
Gotcha, and I think in general , there is some pushback on this idea.
I think Bruno and cos comments are logical : since a +1 requires cultural stuff that we can't get from "just anyone" even if they are knowledgable on some specifics....
So I'm okay to keep things going the way they are, just wanted some feedback on this .
Thanks guys!
> On Dec 23, 2014, at 2:02 AM, Konstantin Boudnik <co...@apache.org> wrote:
>
> -1 (binding)
>
> Here's my reasoning. As Bruno said elsewhere a patch has two parts in it:
> correctness, and cultural and directional fit with the project. While the
> former can be reviewed by a non-committer, the former can not.
>
> On the other hand (and I agree with Bruno again), if a person has
> "demonstrated competency" then such a person needs to be brought on board as a
> committer. Bigtop, unlike quite a few upstream project, has very reasonable
> entry-level expectations. A contributor doesn't have to have a hundred of huge
> patches to be accepted in order to become a committer. So, while I understand
> the urge of unload the committers from some of the reviews, I think it is
> important to a committer to stay well-versed about the development of the
> project, instead of relying on someone else to do said committer's job.
> Instead, a committer in question should be helping a contributor to gain
> enough momentum to gain a commit-bit.
>
> Hopefully, it makes sense.
> Cos
>
>> On Thu, Dec 18, 2014 at 08:02AM, jay vyas wrote:
>> Hi folks. Please cast a vote on this idea,... Its not a huge deal either
>> way, so don't be shy :)... Just thought I'd bring up the idea.
>>
>> I propose : allowing non commiters to +1 patches as sufficient for commit.
>>
>> Why? To increase the ability of external community members to increase
>> productivity in the bigtop process.
>>
>> The proposal: In cases where a developer has proven comptency/expertise in
>> an area of the code base, or significantly knowledgeable on the subject
>> matter or patch in question, we allow a +1 as sufficient for commit.
>>
>> +1 : Its okay for a non-commiter to +1 a commit, and that is sufficient to
>> push a patch to master.
>> -1 : Only commiters can give a official +1 which substantiates to commit to
>> master.
>>
>>
>> Thanks !
>>
>> Jay
Re: [VOTE] Should we allow +1 reviews for bigtop non-commiters with
demonstrated competency?
Posted by Andrew Purtell <ap...@apache.org>.
-1
We shouldn't allow decisions to be made by individuals who haven't earned
merit. As soon as they have, they should be invited to join.
On Wednesday, December 24, 2014, Bruno Mahé <br...@bmahe.net> wrote:
> -1 for the same reasons.
>
> Thanks,
> Bruno
>
> On 12/23/2014 12:02 AM, Konstantin Boudnik wrote:
>
>> -1 (binding)
>>
>> Here's my reasoning. As Bruno said elsewhere a patch has two parts in it:
>> correctness, and cultural and directional fit with the project. While the
>> former can be reviewed by a non-committer, the former can not.
>>
>> On the other hand (and I agree with Bruno again), if a person has
>> "demonstrated competency" then such a person needs to be brought on board
>> as a
>> committer. Bigtop, unlike quite a few upstream project, has very
>> reasonable
>> entry-level expectations. A contributor doesn't have to have a hundred of
>> huge
>> patches to be accepted in order to become a committer. So, while I
>> understand
>> the urge of unload the committers from some of the reviews, I think it is
>> important to a committer to stay well-versed about the development of the
>> project, instead of relying on someone else to do said committer's job.
>> Instead, a committer in question should be helping a contributor to gain
>> enough momentum to gain a commit-bit.
>>
>> Hopefully, it makes sense.
>> Cos
>>
>> On Thu, Dec 18, 2014 at 08:02AM, jay vyas wrote:
>>
>>> Hi folks. Please cast a vote on this idea,... Its not a huge deal
>>> either
>>> way, so don't be shy :)... Just thought I'd bring up the idea.
>>>
>>> I propose : allowing non commiters to +1 patches as sufficient for
>>> commit.
>>>
>>> Why? To increase the ability of external community members to increase
>>> productivity in the bigtop process.
>>>
>>> The proposal: In cases where a developer has proven comptency/expertise
>>> in
>>> an area of the code base, or significantly knowledgeable on the subject
>>> matter or patch in question, we allow a +1 as sufficient for commit.
>>>
>>> +1 : Its okay for a non-commiter to +1 a commit, and that is sufficient
>>> to
>>> push a patch to master.
>>> -1 : Only commiters can give a official +1 which substantiates to commit
>>> to
>>> master.
>>>
>>>
>>> Thanks !
>>>
>>> Jay
>>>
>>
>
--
Best regards,
- Andy
Problems worthy of attack prove their worth by hitting back. - Piet Hein
(via Tom White)
Re: [VOTE] Should we allow +1 reviews for bigtop non-commiters with
demonstrated competency?
Posted by Bruno Mahé <br...@bmahe.net>.
-1 for the same reasons.
Thanks,
Bruno
On 12/23/2014 12:02 AM, Konstantin Boudnik wrote:
> -1 (binding)
>
> Here's my reasoning. As Bruno said elsewhere a patch has two parts in it:
> correctness, and cultural and directional fit with the project. While the
> former can be reviewed by a non-committer, the former can not.
>
> On the other hand (and I agree with Bruno again), if a person has
> "demonstrated competency" then such a person needs to be brought on board as a
> committer. Bigtop, unlike quite a few upstream project, has very reasonable
> entry-level expectations. A contributor doesn't have to have a hundred of huge
> patches to be accepted in order to become a committer. So, while I understand
> the urge of unload the committers from some of the reviews, I think it is
> important to a committer to stay well-versed about the development of the
> project, instead of relying on someone else to do said committer's job.
> Instead, a committer in question should be helping a contributor to gain
> enough momentum to gain a commit-bit.
>
> Hopefully, it makes sense.
> Cos
>
> On Thu, Dec 18, 2014 at 08:02AM, jay vyas wrote:
>> Hi folks. Please cast a vote on this idea,... Its not a huge deal either
>> way, so don't be shy :)... Just thought I'd bring up the idea.
>>
>> I propose : allowing non commiters to +1 patches as sufficient for commit.
>>
>> Why? To increase the ability of external community members to increase
>> productivity in the bigtop process.
>>
>> The proposal: In cases where a developer has proven comptency/expertise in
>> an area of the code base, or significantly knowledgeable on the subject
>> matter or patch in question, we allow a +1 as sufficient for commit.
>>
>> +1 : Its okay for a non-commiter to +1 a commit, and that is sufficient to
>> push a patch to master.
>> -1 : Only commiters can give a official +1 which substantiates to commit to
>> master.
>>
>>
>> Thanks !
>>
>> Jay
Re: [VOTE] Should we allow +1 reviews for bigtop non-commiters with
demonstrated competency?
Posted by Konstantin Boudnik <co...@apache.org>.
-1 (binding)
Here's my reasoning. As Bruno said elsewhere a patch has two parts in it:
correctness, and cultural and directional fit with the project. While the
former can be reviewed by a non-committer, the former can not.
On the other hand (and I agree with Bruno again), if a person has
"demonstrated competency" then such a person needs to be brought on board as a
committer. Bigtop, unlike quite a few upstream project, has very reasonable
entry-level expectations. A contributor doesn't have to have a hundred of huge
patches to be accepted in order to become a committer. So, while I understand
the urge of unload the committers from some of the reviews, I think it is
important to a committer to stay well-versed about the development of the
project, instead of relying on someone else to do said committer's job.
Instead, a committer in question should be helping a contributor to gain
enough momentum to gain a commit-bit.
Hopefully, it makes sense.
Cos
On Thu, Dec 18, 2014 at 08:02AM, jay vyas wrote:
> Hi folks. Please cast a vote on this idea,... Its not a huge deal either
> way, so don't be shy :)... Just thought I'd bring up the idea.
>
> I propose : allowing non commiters to +1 patches as sufficient for commit.
>
> Why? To increase the ability of external community members to increase
> productivity in the bigtop process.
>
> The proposal: In cases where a developer has proven comptency/expertise in
> an area of the code base, or significantly knowledgeable on the subject
> matter or patch in question, we allow a +1 as sufficient for commit.
>
> +1 : Its okay for a non-commiter to +1 a commit, and that is sufficient to
> push a patch to master.
> -1 : Only commiters can give a official +1 which substantiates to commit to
> master.
>
>
> Thanks !
>
> Jay
Re: [VOTE] Should we allow +1 reviews for bigtop non-commiters with
demonstrated competency?
Posted by jay vyas <ja...@gmail.com>.
<bump> :) votes on this guy?
Re: [VOTE] Should we allow +1 reviews for bigtop non-commiters with
demonstrated competency?
Posted by jay vyas <ja...@gmail.com>.
<bump>
-1's are okay, just want to gather opinions on this ! thanks guys...
On Thu, Dec 18, 2014 at 8:02 AM, jay vyas <ja...@gmail.com>
wrote:
>
> Hi folks. Please cast a vote on this idea,... Its not a huge deal either
> way, so don't be shy :)... Just thought I'd bring up the idea.
>
> I propose : allowing non commiters to +1 patches as sufficient for commit.
>
> Why? To increase the ability of external community members to increase
> productivity in the bigtop process.
>
> The proposal: In cases where a developer has proven comptency/expertise in
> an area of the code base, or significantly knowledgeable on the subject
> matter or patch in question, we allow a +1 as sufficient for commit.
>
> +1 : Its okay for a non-commiter to +1 a commit, and that is sufficient
> to push a patch to master.
> -1 : Only commiters can give a official +1 which substantiates to commit
> to master.
>
>
> Thanks !
>
> Jay
>
--
jay vyas