You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by uw...@apache.org on 2019/02/05 10:00:25 UTC
[arrow] branch master updated: ARROW-4477: [JS] remove constructor
override in the bignum mixins
This is an automated email from the ASF dual-hosted git repository.
uwe pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/master by this push:
new 927cfef ARROW-4477: [JS] remove constructor override in the bignum mixins
927cfef is described below
commit 927cfeff875e557e28649891ea20ca38cb9d1536
Author: ptaylor <pa...@me.com>
AuthorDate: Tue Feb 5 11:00:10 2019 +0100
ARROW-4477: [JS] remove constructor override in the bignum mixins
Removes the constructor override leftover from the original `Object.create()` implementation of the bignum mixins. Closes https://issues.apache.org/jira/browse/ARROW-4477
Author: ptaylor <pa...@me.com>
Closes #3557 from trxcllnt/js/fix-bn-constructor and squashes the following commits:
3a468594 <ptaylor> remove constructor override in the bignum mixins
---
js/src/util/bn.ts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/js/src/util/bn.ts b/js/src/util/bn.ts
index 74e3e82..c49c342 100644
--- a/js/src/util/bn.ts
+++ b/js/src/util/bn.ts
@@ -38,9 +38,9 @@ const BigNumNMixin = {
};
/** @ignore */
-const SignedBigNumNMixin: any = Object.assign({}, BigNumNMixin, { signed: true, constructor: undefined });
+const SignedBigNumNMixin: any = Object.assign({}, BigNumNMixin, { signed: true });
/** @ignore */
-const UnsignedBigNumNMixin: any = Object.assign({}, BigNumNMixin, { signed: false, constructor: undefined });
+const UnsignedBigNumNMixin: any = Object.assign({}, BigNumNMixin, { signed: false });
/** @ignore */
export class BN<T extends BigNumArray> {