[GitHub] [commons-lang] garydgregory commented on a change in pull request #757: Use own validator ClassUtils.getName to get String input

[GitBox <gi...@apache.org>]

garydgregory commented on a change in pull request #757:
URL: https://github.com/apache/commons-lang/pull/757#discussion_r820261598



##########
File path: src/main/java/org/apache/commons/lang3/ArrayUtils.java
##########
@@ -3566,7 +3566,7 @@ public static boolean isSameType(final Object array1, final Object array2) {
         if (array1 == null || array2 == null) {
             throw new IllegalArgumentException("The Array must not be null");
         }
-        return array1.getClass().getName().equals(array2.getClass().getName());
+        return ClassUtils.getName(array1).equals(ClassUtils.getName(array2));

Review comment:
       Why? See my comments in your other PR. In this case, neither array1 or array2 can be null here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org