You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/07/23 21:37:41 UTC
Review Request 36742: Fixed the sanity check on OSX for persistent
volumes.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36742/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Marco Massenzio, and Vinod Kone.
Bugs: MESOS-3138
https://issues.apache.org/jira/browse/MESOS-3138
Repository: mesos
Description
-------
Fixed the sanity check on OSX for persistent volumes.
Diffs
-----
src/slave/containerizer/isolators/filesystem/posix.cpp 0c5662741a7562872f0dbfaf9c9b6d923d80af5d
Diff: https://reviews.apache.org/r/36742/diff/
Testing
-------
make check on OSX
Thanks,
Jie Yu
Re: Review Request 36742: Fixed the sanity check on OSX for persistent
volumes.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36742/#review92799
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36742]
All tests passed.
- Mesos ReviewBot
On July 23, 2015, 7:37 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36742/
> -----------------------------------------------------------
>
> (Updated July 23, 2015, 7:37 p.m.)
>
>
> Review request for mesos, Ben Mahler, Marco Massenzio, and Vinod Kone.
>
>
> Bugs: MESOS-3138
> https://issues.apache.org/jira/browse/MESOS-3138
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed the sanity check on OSX for persistent volumes.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/filesystem/posix.cpp 0c5662741a7562872f0dbfaf9c9b6d923d80af5d
>
> Diff: https://reviews.apache.org/r/36742/diff/
>
>
> Testing
> -------
>
> make check on OSX
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 36742: Fixed the sanity check on OSX for persistent
volumes.
Posted by Jie Yu <yu...@gmail.com>.
> On July 23, 2015, 8:15 p.m., Marco Massenzio wrote:
> > LGTM
> >
> > Could you maybe add a comment or something to indicate why this failed on OSX (and what the fix was), in case someone introduces something similar in future, we'll have a reference to guide us.
> >
> > Thanks for super-quick fix!
Added more comments.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36742/#review92798
-----------------------------------------------------------
On July 23, 2015, 7:37 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36742/
> -----------------------------------------------------------
>
> (Updated July 23, 2015, 7:37 p.m.)
>
>
> Review request for mesos, Ben Mahler, Marco Massenzio, and Vinod Kone.
>
>
> Bugs: MESOS-3138
> https://issues.apache.org/jira/browse/MESOS-3138
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed the sanity check on OSX for persistent volumes.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/filesystem/posix.cpp 0c5662741a7562872f0dbfaf9c9b6d923d80af5d
>
> Diff: https://reviews.apache.org/r/36742/diff/
>
>
> Testing
> -------
>
> make check on OSX
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 36742: Fixed the sanity check on OSX for persistent
volumes.
Posted by Marco Massenzio <ma...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36742/#review92798
-----------------------------------------------------------
Ship it!
LGTM
Could you maybe add a comment or something to indicate why this failed on OSX (and what the fix was), in case someone introduces something similar in future, we'll have a reference to guide us.
Thanks for super-quick fix!
- Marco Massenzio
On July 23, 2015, 7:37 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36742/
> -----------------------------------------------------------
>
> (Updated July 23, 2015, 7:37 p.m.)
>
>
> Review request for mesos, Ben Mahler, Marco Massenzio, and Vinod Kone.
>
>
> Bugs: MESOS-3138
> https://issues.apache.org/jira/browse/MESOS-3138
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed the sanity check on OSX for persistent volumes.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/filesystem/posix.cpp 0c5662741a7562872f0dbfaf9c9b6d923d80af5d
>
> Diff: https://reviews.apache.org/r/36742/diff/
>
>
> Testing
> -------
>
> make check on OSX
>
>
> Thanks,
>
> Jie Yu
>
>