You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apisix.apache.org by Ming Wen <we...@apache.org> on 2019/11/01 08:13:08 UTC

[LICENSE] question about apisix-dashboard

hello, mentors,
    We have two standalone repositories about dashboard:
incubator-apisix-dashboard[1] and incubator-apisix-dashboard-built [2].
    The first one is the source code of APISIX dashboard, and not including
in APISIX repo [3];
another one is the production build files from the first one through yarn,
and bundle in APISIX repo as a submodule.

so I am not sure which way to declare the license and copyright of the
dashboard in APISIX is appropriate:
    1. add incubator-apisix-dashboard's license, but APISIX does not
contain the code of incubator-apisix-dashboard;
    2. add incubator-apisix-dashboard and incubator-apisix-dashboard
dependencies' licenses;
    3. no license for dashboard.

 Is there a better way to deal with the license for frontend production
build files?

[1] https://github.com/apache/incubator-apisix-dashboard
[2] https://github.com/apache/incubator-apisix-dashboard-built
[3] https://github.com/apache/incubator-apisix

Thanks,
Ming Wen, Apache APISIX
Twitter: _WenMing

Re: [LICENSE] question about apisix-dashboard

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

> Could you help to give some advice about the incoming release of this
> dashboard?

I’ll take a look, but can you point me a release candidate or similar that I can check? It not really possible to check a report as what goes into a release may be different.

Thanks,
Justin

Re: [LICENSE] question about apisix-dashboard

Posted by Zhiyuan Ju <ju...@apache.org>.
Hi Justin,

Thanks for your reply, then we will be ready to initiate a release vote
soon after.

Best Regards!
@ Zhiyuan Ju <https://www.shaoyaoju.org/>


Justin Mclean <ju...@classsoftware.com> 于2019年12月14日周六 上午10:09写道:

> Hi,
> Is you delt with [1] above then I would say all is good.
> Thanks,
> Justin
>
> On Sat, 14 Dec 2019, 12:43 Zhiyuan Ju, <ju...@apache.org> wrote:
>
> > Hi,
> >
> > I'd love to know any updates here? and could we initiate a Vote for
> > releasing Dashboard?
> >
> > Best Regards!
> > @ Zhiyuan Ju <https://www.shaoyaoju.org/>
> >
> >
> > Zhiyuan Ju <ju...@apache.org> 于2019年12月8日周日 上午10:01写道:
> >
> > > Hi Justin,
> > >
> > > Thanks for your reply!
> > >
> > > - where did those codes [1] come from?
> > > Those codes are generated by the vue-typescript-admin-template[1]
> > > boilerplate. I will add their License information soon.
> > >
> > > - A large number of files (40 odd) are Copyright 2018 Chong Guo is this
> > > correct? That more files than have ASF licenses.
> > > Those files which are generated by the vue-typescript-admin-template[1]
> > > boilerplate will mark as Copyright 2018 Chong Guo. That's correct. In
> our
> > > Incubator Apache APISIX Dashboard, we mainly created and use files
> under:
> > >
> > >    - /src/api/
> > >    - /src/components/PluginDialog/
> > >    - /src/router/
> > >    - /src/views/schema/
> > >
> > > - but can you point me a release candidate or similar that I can check?
> > > We would like to know if those source files under
> > > the incubator-apisix-dashboard[2] repository are License valid :) Then
> we
> > > could continue to starting a release vote and so on.
> > >
> > > [1] vue-typescript-admin-template
> > > <https://github.com/Armour/vue-typescript-admin-template>
> > > [2] https://github.com/apache/incubator-apisix-dashboard
> > >
> > > Best Regards!
> > > @ Zhiyuan Ju <https://www.shaoyaoju.org/>
> > >
> > >
> > > Justin Mclean <ju...@classsoftware.com> 于2019年12月8日周日 上午7:01写道:
> > >
> > >> Hi,
> > >>
> > >>  A couple of questions:
> > >> - where did this this code [1] come from?
> > >> - A large number of files (40 odd) are Copyright 2018 Chong Guo is
> this
> > >> correct? That more files than have ASF licenses.
> > >>
> > >> Thanks,
> > >> Justin
> > >>
> > >> 1. ./src/styles/*.scss
> > >>
> > >>
> >
>

Re: [LICENSE] question about apisix-dashboard

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
Is you delt with [1] above then I would say all is good.
Thanks,
Justin

On Sat, 14 Dec 2019, 12:43 Zhiyuan Ju, <ju...@apache.org> wrote:

> Hi,
>
> I'd love to know any updates here? and could we initiate a Vote for
> releasing Dashboard?
>
> Best Regards!
> @ Zhiyuan Ju <https://www.shaoyaoju.org/>
>
>
> Zhiyuan Ju <ju...@apache.org> 于2019年12月8日周日 上午10:01写道:
>
> > Hi Justin,
> >
> > Thanks for your reply!
> >
> > - where did those codes [1] come from?
> > Those codes are generated by the vue-typescript-admin-template[1]
> > boilerplate. I will add their License information soon.
> >
> > - A large number of files (40 odd) are Copyright 2018 Chong Guo is this
> > correct? That more files than have ASF licenses.
> > Those files which are generated by the vue-typescript-admin-template[1]
> > boilerplate will mark as Copyright 2018 Chong Guo. That's correct. In our
> > Incubator Apache APISIX Dashboard, we mainly created and use files under:
> >
> >    - /src/api/
> >    - /src/components/PluginDialog/
> >    - /src/router/
> >    - /src/views/schema/
> >
> > - but can you point me a release candidate or similar that I can check?
> > We would like to know if those source files under
> > the incubator-apisix-dashboard[2] repository are License valid :) Then we
> > could continue to starting a release vote and so on.
> >
> > [1] vue-typescript-admin-template
> > <https://github.com/Armour/vue-typescript-admin-template>
> > [2] https://github.com/apache/incubator-apisix-dashboard
> >
> > Best Regards!
> > @ Zhiyuan Ju <https://www.shaoyaoju.org/>
> >
> >
> > Justin Mclean <ju...@classsoftware.com> 于2019年12月8日周日 上午7:01写道:
> >
> >> Hi,
> >>
> >>  A couple of questions:
> >> - where did this this code [1] come from?
> >> - A large number of files (40 odd) are Copyright 2018 Chong Guo is this
> >> correct? That more files than have ASF licenses.
> >>
> >> Thanks,
> >> Justin
> >>
> >> 1. ./src/styles/*.scss
> >>
> >>
>

Re: [LICENSE] question about apisix-dashboard

Posted by Zhiyuan Ju <ju...@apache.org>.
Hi,

I'd love to know any updates here? and could we initiate a Vote for
releasing Dashboard?

Best Regards!
@ Zhiyuan Ju <https://www.shaoyaoju.org/>


Zhiyuan Ju <ju...@apache.org> 于2019年12月8日周日 上午10:01写道:

> Hi Justin,
>
> Thanks for your reply!
>
> - where did those codes [1] come from?
> Those codes are generated by the vue-typescript-admin-template[1]
> boilerplate. I will add their License information soon.
>
> - A large number of files (40 odd) are Copyright 2018 Chong Guo is this
> correct? That more files than have ASF licenses.
> Those files which are generated by the vue-typescript-admin-template[1]
> boilerplate will mark as Copyright 2018 Chong Guo. That's correct. In our
> Incubator Apache APISIX Dashboard, we mainly created and use files under:
>
>    - /src/api/
>    - /src/components/PluginDialog/
>    - /src/router/
>    - /src/views/schema/
>
> - but can you point me a release candidate or similar that I can check?
> We would like to know if those source files under
> the incubator-apisix-dashboard[2] repository are License valid :) Then we
> could continue to starting a release vote and so on.
>
> [1] vue-typescript-admin-template
> <https://github.com/Armour/vue-typescript-admin-template>
> [2] https://github.com/apache/incubator-apisix-dashboard
>
> Best Regards!
> @ Zhiyuan Ju <https://www.shaoyaoju.org/>
>
>
> Justin Mclean <ju...@classsoftware.com> 于2019年12月8日周日 上午7:01写道:
>
>> Hi,
>>
>>  A couple of questions:
>> - where did this this code [1] come from?
>> - A large number of files (40 odd) are Copyright 2018 Chong Guo is this
>> correct? That more files than have ASF licenses.
>>
>> Thanks,
>> Justin
>>
>> 1. ./src/styles/*.scss
>>
>>

Re: [LICENSE] question about apisix-dashboard

Posted by Zhiyuan Ju <ju...@apache.org>.
Hi Justin,

Thanks for your reply!

- where did those codes [1] come from?
Those codes are generated by the vue-typescript-admin-template[1]
boilerplate. I will add their License information soon.

- A large number of files (40 odd) are Copyright 2018 Chong Guo is this
correct? That more files than have ASF licenses.
Those files which are generated by the vue-typescript-admin-template[1]
boilerplate will mark as Copyright 2018 Chong Guo. That's correct. In our
Incubator Apache APISIX Dashboard, we mainly created and use files under:

   - /src/api/
   - /src/components/PluginDialog/
   - /src/router/
   - /src/views/schema/

- but can you point me a release candidate or similar that I can check?
We would like to know if those source files under
the incubator-apisix-dashboard[2] repository are License valid :) Then we
could continue to starting a release vote and so on.

[1] vue-typescript-admin-template
<https://github.com/Armour/vue-typescript-admin-template>
[2] https://github.com/apache/incubator-apisix-dashboard

Best Regards!
@ Zhiyuan Ju <https://www.shaoyaoju.org/>


Justin Mclean <ju...@classsoftware.com> 于2019年12月8日周日 上午7:01写道:

> Hi,
>
>  A couple of questions:
> - where did this this code [1] come from?
> - A large number of files (40 odd) are Copyright 2018 Chong Guo is this
> correct? That more files than have ASF licenses.
>
> Thanks,
> Justin
>
> 1. ./src/styles/*.scss
>
>

Re: [LICENSE] question about apisix-dashboard

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

 A couple of questions:
- where did this this code [1] come from?
- A large number of files (40 odd) are Copyright 2018 Chong Guo is this correct? That more files than have ASF licenses.

Thanks,
Justin

1. ./src/styles/*.scss


Re: [LICENSE] question about apisix-dashboard

Posted by Zhiyuan Ju <ju...@apache.org>.
Hi Justin,

I just checked every file under the incubator-apisix-dashboard[1]
repository:
- There has the ALv2 License information at the beginning of every file we
created except txt, png, env.
- Those files which are generated by boilerplate have their MIT License
information.
- README file has the installation method.
- Only Apache APISIX's logo file is kept under /public folder, all other
images are removed.

Could you help to give some advice about the incoming release of this
dashboard?

[1] https://github.com/apache/incubator-apisix-dashboard

Best Regards!
@ Zhiyuan Ju <https://www.shaoyaoju.org/>


Justin Mclean <ju...@classsoftware.com> 于2019年11月8日周五 下午1:29写道:

> Hi,
>
> The LICENSE and NOTICE need to reflect what is in the release, if the code
> is not bundled then there no need to add it to LICENSE (or NOTICE).
>
> If the dashboard is not included then there no need to add it’s license
> (which with be ALv2 anyway).
>
> Thanks,
> Justin

Re: [LICENSE] question about apisix-dashboard

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

The LICENSE and NOTICE need to reflect what is in the release, if the code is not bundled then there no need to add it to LICENSE (or NOTICE).

If the dashboard is not included then there no need to add it’s license (which with be ALv2 anyway).

Thanks,
Justin

Re: [DISCUSS] I think we should move enable_web_socket to routes rather in plugin

Posted by YuanSheng Wang <me...@gmail.com>.
Hi:

You just listed the CDN scenario, but we are an API gateway.

Using enable_websocket as an upstream option may be wrong. For the
grpc protocol, there is no such option.


On Tue, Nov 5, 2019 at 11:14 PM 李凌Lien <li...@qq.com> wrote:

> &nbsp; &nbsp;
> &nbsp; &nbsp; &nbsp;I think the websocket usually means a upstream server
> that serve as websocket server.
> &nbsp; &nbsp; &nbsp;which I think we could move the websocket function
> enable button to upstream configration page.
> &nbsp; &nbsp;
> &nbsp; &nbsp; &nbsp;the idea that move the websocket controller to
> upstream is from Cloud Service.&nbsp; &nbsp;&nbsp;
>
>
> &nbsp; &nbsp; I&nbsp; used Alibaba cloud DCDN service before, after setup
> the DCDN(dynamic CDN) domain and upstream, it cloud indicate that whether
> support websocket function。
>
>
>
> Mail&nbsp;from Lien
>
>
> &nbsp;
>
>
>
>
> ------------------&nbsp;原始邮件&nbsp;------------------
> 发件人:&nbsp;"李凌Lien"<lilien3838@qq.com&gt;;
> 发送时间:&nbsp;2019年11月3日(星期天) 下午5:40
> 收件人:&nbsp;"dev"<dev@apisix.apache.org&gt;;
>
> 主题:&nbsp;[DISCUSS] I think we should move enable_web_socket to routes
> rather in plugin
>
>
>
> &nbsp; &nbsp; Hi guys,
> &nbsp; &nbsp; for now the web socket&nbsp; enable button is hidden in
> proxy-rewrite plugin, which I think is very inconvenient for users to put a
> web-socket server behind APISIX.
> &nbsp; &nbsp;proxy-write is more like NGINX parameter modifier, rather
> than service or function controller to enable or disable some features.
> &nbsp;
> &nbsp; &nbsp;Scenario:
> &nbsp; &nbsp;When I have a web socket server explode URI like this
> /web_socket/123456,(123456 is a URI var)。
> &nbsp; &nbsp;then I create a router&nbsp; /web_socket/*.
> &nbsp; &nbsp;here comes the problem if I use proxy-write, no doubt I want
> keep the URI same to backend server while enable the web-socket .
>
> &nbsp;
> &nbsp;
>
> Mail from Lien@HelloTalk
>
>
> &nbsp;
> &nbsp;



-- 

*MembPhis*
My github: https://github.com/membphis
Apache APISIX: https://github.com/apache/incubator-apisix

[DISCUSS] I think we should move enable_web_socket to routes rather in plugin

Posted by 李凌Lien <li...@qq.com>.
&nbsp; &nbsp;
&nbsp; &nbsp; &nbsp;I think the websocket usually means a upstream server that serve as websocket server.
&nbsp; &nbsp; &nbsp;which I think we could move the websocket function enable button to upstream configration page.
&nbsp; &nbsp;
&nbsp; &nbsp; &nbsp;the idea that move the websocket controller to upstream is from Cloud Service.&nbsp; &nbsp;&nbsp;


&nbsp; &nbsp; I&nbsp; used Alibaba cloud DCDN service before, after setup the DCDN(dynamic CDN) domain and upstream, it cloud indicate that whether support websocket function。



Mail&nbsp;from Lien


&nbsp;




------------------&nbsp;原始邮件&nbsp;------------------
发件人:&nbsp;"李凌Lien"<lilien3838@qq.com&gt;;
发送时间:&nbsp;2019年11月3日(星期天) 下午5:40
收件人:&nbsp;"dev"<dev@apisix.apache.org&gt;;

主题:&nbsp;[DISCUSS] I think we should move enable_web_socket to routes rather in plugin



&nbsp; &nbsp; Hi guys, 
&nbsp; &nbsp; for now the web socket&nbsp; enable button is hidden in proxy-rewrite plugin, which I think is very inconvenient for users to put a web-socket server behind APISIX.
&nbsp; &nbsp;proxy-write is more like NGINX parameter modifier, rather than service or function controller to enable or disable some features.
&nbsp;
&nbsp; &nbsp;Scenario:
&nbsp; &nbsp;When I have a web socket server explode URI like this /web_socket/123456,(123456 is a URI var)。
&nbsp; &nbsp;then I create a router&nbsp; /web_socket/*.
&nbsp; &nbsp;here comes the problem if I use proxy-write, no doubt I want keep the URI same to backend server while enable the web-socket .

&nbsp;
&nbsp; 

Mail from Lien@HelloTalk


&nbsp;
&nbsp;

Re: [DISCUSS] I think we should move enable_web_socket to routes rather in plugin

Posted by JinChao Shuai <sh...@apache.org>.
Dear, 李凌Lien
Because everyone's use scenarios are different. If it is configured in the
upstream module, the upstream can only be used as websocket service. The
current configuration mode will be more flexible than that in upstream. But
you mentioned that rewriting URIs to support fuzzy matching is a good idea.

李凌Lien <li...@qq.com> 于2019年11月3日周日 下午5:43写道:

> Hi guys,
>     for now the web socket  enable button is hidden in proxy-rewrite
> plugin, which I think is very inconvenient for users to put a web-socket
> server behind APISIX.
>    proxy-write is more like NGINX parameter modifier, rather than service
> or function controller to enable or disable some features.
>
>    Scenario:
>    When I have a web socket server explode URI like this
> /web_socket/123456,(123456 is a URI var)。
>    then I create a router  /web_socket/*.
>    here comes the problem if I use proxy-write, no doubt I want keep the
> URI same to backend server while enable the web-socket .
>
>
>
>
> Mail from Lien@HelloTalk

[DISCUSS] I think we should move enable_web_socket to routes rather in plugin

Posted by 李凌Lien <li...@qq.com>.
Hi guys, 
    for now the web socket  enable button is hidden in proxy-rewrite plugin, which I think is very inconvenient for users to put a web-socket server behind APISIX.
   proxy-write is more like NGINX parameter modifier, rather than service or function controller to enable or disable some features.
 
   Scenario:
   When I have a web socket server explode URI like this /web_socket/123456,(123456 is a URI var)。
   then I create a router  /web_socket/*.
   here comes the problem if I use proxy-write, no doubt I want keep the URI same to backend server while enable the web-socket .

 
  

Mail from Lien@HelloTalk

Re: [LICENSE] question about apisix-dashboard

Posted by Justin Mclean <ju...@me.com>.
Hi,

> The incubator-apisix-dashboard repo is using one template which is under
> MIT License, so we'd like to know which license is suitable for the
> incubator-apisix-dashboard-built repo?

If the release contains something under the MIT license, then you leave the header as MIT, and you add the MIT license to the LICENSE file. [1

] Is [2] a dependancy or is the code actually in the release?  Assuming it’s bundled the existing LICENSE file doesn’t look correct to me, while it mentions the MIT license, it doesn’t include the full text of the license or a pointer to a file containing that text. A URL can change over time so you need more than just that.

Currently it’s a little hard to give any advice as the files are missing headers so I don’t know what their origin was and which file(s) are 3rd party. Have the original file headers been removed?

Thanks,
Justin

1. http://www.apache.org/dev/licensing-howto.html#permissive-deps
2. https://github.com/PanJiaChen/vue-element-admin

Re: [LICENSE] question about apisix-dashboard

Posted by Zhiyuan Ju <ju...@apache.org>.
Hi Justin,

For the first issue, it means that our incubator-apisix repo contains one
submodule called dashboard, which is linked to the
incubator-apisix-dashboard-built  repo and contains production files
generated by another repo called incubator-apisix-dashboard.

The incubator-apisix-dashboard repo is using one template which is under
MIT License, so we'd like to know which license is suitable for the
incubator-apisix-dashboard-built repo?



Ming Wen <we...@apache.org> 于 2019年11月4日周一 22:46写道:

> Hi, Justin,
> https://www.apache.org/legal/src-headers.html#3party solved my confusion,
> thanks.
>
> Zhiyuan, can you explain the first issue in more detail? I feel that it can
> be solved in the same way.
>
> Thanks,
> Ming Wen, Apache APISIX
> Twitter: _WenMing
>
>
> Justin Mclean <ju...@classsoftware.com> 于2019年11月4日周一 下午10:25写道:
>
> > Hi,
> >
> > > I have two issues about the dashboard license so far
> >
> > I replied to this before.
> >
> > > 1. The first one is the question mentioned in the email above:
> > >    how to deal with the license for frontend production build files in
> > > incubator-apisix-dashboard-built [1]?
> >
> > It ALv2 in an apache repo so what’s the issue?
> >
> > > 2. The second is that the dashboard is based on vue-element-admin[3],
> > > we need to carefully sort out which files should keep the original MIT
> > > license and which our modified files can add the apache license header.
> >
> > That's easy, all files should keep the original MIT license. If you have
> > permission from the owner you can change it, but otherwise unless their
> are
> > significant changes it is best to keep the original header and license.
> [1]
> >
> > Thanks,
> > Justin
> >
> > 1. https://www.apache.org/legal/src-headers.html#3party
>

Re: [LICENSE] question about apisix-dashboard

Posted by Ming Wen <we...@apache.org>.
Hi, Justin,
https://www.apache.org/legal/src-headers.html#3party solved my confusion,
thanks.

Zhiyuan, can you explain the first issue in more detail? I feel that it can
be solved in the same way.

Thanks,
Ming Wen, Apache APISIX
Twitter: _WenMing


Justin Mclean <ju...@classsoftware.com> 于2019年11月4日周一 下午10:25写道:

> Hi,
>
> > I have two issues about the dashboard license so far
>
> I replied to this before.
>
> > 1. The first one is the question mentioned in the email above:
> >    how to deal with the license for frontend production build files in
> > incubator-apisix-dashboard-built [1]?
>
> It ALv2 in an apache repo so what’s the issue?
>
> > 2. The second is that the dashboard is based on vue-element-admin[3],
> > we need to carefully sort out which files should keep the original MIT
> > license and which our modified files can add the apache license header.
>
> That's easy, all files should keep the original MIT license. If you have
> permission from the owner you can change it, but otherwise unless their are
> significant changes it is best to keep the original header and license. [1]
>
> Thanks,
> Justin
>
> 1. https://www.apache.org/legal/src-headers.html#3party

Re: [LICENSE] question about apisix-dashboard

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

> Then should we use the original repo MIT License[1]?

I would suggest so yes.

> Also, if we could change the package.json file's contents such as author,
> name, repository [2]?

Well is not long that package I assume so that will have to change, the other it depends if it referring to the whole thing or just the original code.

Thanks,
Justin

Re: [LICENSE] question about apisix-dashboard

Posted by Ming Wen <we...@apache.org>.
I am not sure about that.
Justin, what's your opinion?

Thanks,
Ming Wen, Apache APISIX
Twitter: _WenMing


Zhiyuan Ju <ju...@apache.org> 于2019年11月7日周四 下午12:06写道:

> Hi Ming,
>
> Then should we use the original repo MIT License[1]?
>
> Also, if we could change the package.json file's contents such as author,
> name, repository [2]?
>
> [1]
> https://github.com/Armour/vue-typescript-admin-template/blob/master/LICENSE
> [2]
>
> https://github.com/apache/incubator-apisix-dashboard/blob/master/package.json#L5
>
> Best Regards!
> @ Zhiyuan Ju <https://www.shaoyaoju.org/>
>
>
> Ming Wen <we...@apache.org> 于2019年11月7日周四 下午12:00写道:
>
> > Cool, it's time to do that.
> >
> > Thanks,
> > Ming Wen, Apache APISIX
> > Twitter: _WenMing
> >
> >
> > Zhiyuan Ju <ju...@apache.org> 于2019年11月7日周四 上午11:59写道:
> >
> > > Hi Ming,
> > >
> > > I have merged two Feature PRs just now and removed all unused files as
> > > possible as I can, also I just updated the
> > incubator-apisix-dashboard-built
> > > repository, so I think if it's a good time to add MIT License Headers
> to
> > > those existing original files? [1]
> > >
> > > [1] https://github.com/apache/incubator-apisix-dashboard/issues/66
> > >
> > > Best Regards!
> > > @ Zhiyuan Ju <https://www.shaoyaoju.org/>
> > >
> > >
> > > Justin Mclean <ju...@classsoftware.com> 于2019年11月6日周三 上午7:30写道:
> > >
> > > > Hi,
> > > >
> > > > > 3. start developing: create our needed files or modify existing
> > files;
> > > >
> > > > You'll need to distinguish between the files you have created and
> their
> > > > files. I would suggest adding a MIT header to their files to make it
> > > clear
> > > > where they are from and that they are not ALv2.
> > > >
> > > > If you have headily modified one of their files when discuss here if
> > the
> > > > header should change to an ALv2 one, in general it should not.
> > > >
> > > > Thanks,
> > > > Justin
> > > >
> > > >
> > >
> >
>

Re: [LICENSE] question about apisix-dashboard

Posted by Zhiyuan Ju <ju...@apache.org>.
Hi Ming,

Then should we use the original repo MIT License[1]?

Also, if we could change the package.json file's contents such as author,
name, repository [2]?

[1]
https://github.com/Armour/vue-typescript-admin-template/blob/master/LICENSE
[2]
https://github.com/apache/incubator-apisix-dashboard/blob/master/package.json#L5

Best Regards!
@ Zhiyuan Ju <https://www.shaoyaoju.org/>


Ming Wen <we...@apache.org> 于2019年11月7日周四 下午12:00写道:

> Cool, it's time to do that.
>
> Thanks,
> Ming Wen, Apache APISIX
> Twitter: _WenMing
>
>
> Zhiyuan Ju <ju...@apache.org> 于2019年11月7日周四 上午11:59写道:
>
> > Hi Ming,
> >
> > I have merged two Feature PRs just now and removed all unused files as
> > possible as I can, also I just updated the
> incubator-apisix-dashboard-built
> > repository, so I think if it's a good time to add MIT License Headers to
> > those existing original files? [1]
> >
> > [1] https://github.com/apache/incubator-apisix-dashboard/issues/66
> >
> > Best Regards!
> > @ Zhiyuan Ju <https://www.shaoyaoju.org/>
> >
> >
> > Justin Mclean <ju...@classsoftware.com> 于2019年11月6日周三 上午7:30写道:
> >
> > > Hi,
> > >
> > > > 3. start developing: create our needed files or modify existing
> files;
> > >
> > > You'll need to distinguish between the files you have created and their
> > > files. I would suggest adding a MIT header to their files to make it
> > clear
> > > where they are from and that they are not ALv2.
> > >
> > > If you have headily modified one of their files when discuss here if
> the
> > > header should change to an ALv2 one, in general it should not.
> > >
> > > Thanks,
> > > Justin
> > >
> > >
> >
>

Re: [LICENSE] question about apisix-dashboard

Posted by Ming Wen <we...@apache.org>.
Cool, it's time to do that.

Thanks,
Ming Wen, Apache APISIX
Twitter: _WenMing


Zhiyuan Ju <ju...@apache.org> 于2019年11月7日周四 上午11:59写道:

> Hi Ming,
>
> I have merged two Feature PRs just now and removed all unused files as
> possible as I can, also I just updated the incubator-apisix-dashboard-built
> repository, so I think if it's a good time to add MIT License Headers to
> those existing original files? [1]
>
> [1] https://github.com/apache/incubator-apisix-dashboard/issues/66
>
> Best Regards!
> @ Zhiyuan Ju <https://www.shaoyaoju.org/>
>
>
> Justin Mclean <ju...@classsoftware.com> 于2019年11月6日周三 上午7:30写道:
>
> > Hi,
> >
> > > 3. start developing: create our needed files or modify existing files;
> >
> > You'll need to distinguish between the files you have created and their
> > files. I would suggest adding a MIT header to their files to make it
> clear
> > where they are from and that they are not ALv2.
> >
> > If you have headily modified one of their files when discuss here if the
> > header should change to an ALv2 one, in general it should not.
> >
> > Thanks,
> > Justin
> >
> >
>

Re: [LICENSE] question about apisix-dashboard

Posted by Zhiyuan Ju <ju...@apache.org>.
Hi Ming,

I have merged two Feature PRs just now and removed all unused files as
possible as I can, also I just updated the incubator-apisix-dashboard-built
repository, so I think if it's a good time to add MIT License Headers to
those existing original files? [1]

[1] https://github.com/apache/incubator-apisix-dashboard/issues/66

Best Regards!
@ Zhiyuan Ju <https://www.shaoyaoju.org/>


Justin Mclean <ju...@classsoftware.com> 于2019年11月6日周三 上午7:30写道:

> Hi,
>
> > 3. start developing: create our needed files or modify existing files;
>
> You'll need to distinguish between the files you have created and their
> files. I would suggest adding a MIT header to their files to make it clear
> where they are from and that they are not ALv2.
>
> If you have headily modified one of their files when discuss here if the
> header should change to an ALv2 one, in general it should not.
>
> Thanks,
> Justin
>
>

Re: [LICENSE] question about apisix-dashboard

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

> 3. start developing: create our needed files or modify existing files;

You'll need to distinguish between the files you have created and their files. I would suggest adding a MIT header to their files to make it clear where they are from and that they are not ALv2.

If you have headily modified one of their files when discuss here if the header should change to an ALv2 one, in general it should not.

Thanks,
Justin


Re: [LICENSE] question about apisix-dashboard

Posted by Zhiyuan Ju <ju...@apache.org>.
Hi,

The following are steps to building our dashboard:

1. clone the vue-element-admin repository;
2. remove all unused files from this repository;
3. start developing: create our needed files or modify existing files;
4. push files to our incubator-apisix-dashboard repoisory;
5. push release production files to incubator-apisix-dashboard-built
repoisory;

I hope it helps :)

Best Regards!
@ Zhiyuan Ju <https://www.shaoyaoju.org/>


Justin Mclean <ju...@classsoftware.com> 于2019年11月5日周二 上午11:30写道:

> HI,
>
> > This repository[1] is a kind of Vue.js scaffolds, under MIT License, and
> we
> > can use this repository's rich components to build Dashboard :)
>
> I’m still a little confused if file from this repo have been copied to one
> of our repos or it is just been used as a dependancy.
>
> Thanks,
> Just8in

Re: [LICENSE] question about apisix-dashboard

Posted by Justin Mclean <ju...@classsoftware.com>.
HI,

> This repository[1] is a kind of Vue.js scaffolds, under MIT License, and we
> can use this repository's rich components to build Dashboard :)

I’m still a little confused if file from this repo have been copied to one of our repos or it is just been used as a dependancy.

Thanks,
Just8in

Re: [LICENSE] question about apisix-dashboard

Posted by Zhiyuan Ju <ju...@apache.org>.
Hi Justin,

> The incubator-apisix-dashboard repo is using one template which is under

> MIT License, so we'd like to know which license is suitable for the

> incubator-apisix-dashboard-built repo?


If the release contains something under the MIT license, then you leave the
> header as MIT, and you add the MIT license to the LICENSE file. [1
> ] Is [2] a dependancy or is the code actually in the release?  Assuming
> it’s bundled the existing LICENSE file doesn’t look correct to me, while it
> mentions the MIT license, it doesn’t include the full text of the license
> or a pointer to a file containing that text. A URL can change over time so
> you need more than just that.
> Currently it’s a little hard to give any advice as the files are missing
> headers so I don’t know what their origin was and which file(s) are 3rd
> party. Have the original file headers been removed?
> Thanks,
> Justin
> 1. http://www.apache.org/dev/licensing-howto.html#permissive-deps
> 2. https://github.com/PanJiaChen/vue-element-admin


The mail above was blocked because you might use a different mail address 😅


This repository[1] is a kind of Vue.js scaffolds, under MIT License, and we
can use this repository's rich components to build Dashboard :)


The original files do not include any Hader content, we just added the ASF
Header to original files by mistaken :)


[1] https://github.com/PanJiaChen/vue-element-admin


Best Regards!
@ Zhiyuan Ju <https://www.shaoyaoju.org/>


Zhiyuan Ju <ju...@apache.org> 于2019年11月5日周二 上午9:35写道:

> Thanks for your reply :)
>
> So for the incubator-apisix-dashboard-built repository which contains the
> release files should be under Apache License even if it's generated by the
> incubator-apisix-dashboard repository (under MIT License)?
>
> Best Regards!
> @ Zhiyuan Ju <https://www.shaoyaoju.org/>
>
>
> Justin Mclean <ju...@classsoftware.com> 于2019年11月5日周二 上午8:36写道:
>
>> Sorry for bad autocorrect in my last message.
>>
>> It depends on who owns the IP of the file. You should never remove or
>> replace a 3rd party header from a file without their permission even if
>> you
>> have made changes.
>>
>> On Tue, 5 Nov 2019, 11:33 Justin Mclean, <ju...@classsoftware.com>
>> wrote:
>>
>> > Hi,
>> > It celebs who the filed necking to and who owns the IP on each file. The
>> > release should be under the Apache license that's required.
>> > Thanks,
>> > Justin
>> >
>> > On Tue, 5 Nov 2019, 11:15 Zhiyuan Ju, <ju...@apache.org> wrote:
>> >
>> >> Hi Justin,
>> >>
>> >> Just to make sure, for the incubator-apisix-dashboard repo, all
>> unchanged
>> >> files should remove our ALv2 header and all significant
>> >>  changes files will be added the ALv2 header, and the repo will keep
>> the
>> >> MIT License?
>> >>
>> >> Justin Mclean <ju...@classsoftware.com> 于 2019年11月4日周一 22:25写道:
>> >>
>> >> > Hi,
>> >> >
>> >> > > I have two issues about the dashboard license so far
>> >> >
>> >> > I replied to this before.
>> >> >
>> >> > > 1. The first one is the question mentioned in the email above:
>> >> > >    how to deal with the license for frontend production build
>> files in
>> >> > > incubator-apisix-dashboard-built [1]?
>> >> >
>> >> > It ALv2 in an apache repo so what’s the issue?
>> >> >
>> >> > > 2. The second is that the dashboard is based on
>> vue-element-admin[3],
>> >> > > we need to carefully sort out which files should keep the original
>> MIT
>> >> > > license and which our modified files can add the apache license
>> >> header.
>> >> >
>> >> > That's easy, all files should keep the original MIT license. If you
>> have
>> >> > permission from the owner you can change it, but otherwise unless
>> their
>> >> are
>> >> > significant changes it is best to keep the original header and
>> license.
>> >> [1]
>> >> >
>> >> > Thanks,
>> >> > Justin
>> >> >
>> >> > 1. https://www.apache.org/legal/src-headers.html#3party
>> >>
>> >
>>
>

Re: [LICENSE] question about apisix-dashboard

Posted by Zhiyuan Ju <ju...@apache.org>.
Thanks for your reply :)

So for the incubator-apisix-dashboard-built repository which contains the
release files should be under Apache License even if it's generated by the
incubator-apisix-dashboard repository (under MIT License)?

Best Regards!
@ Zhiyuan Ju <https://www.shaoyaoju.org/>


Justin Mclean <ju...@classsoftware.com> 于2019年11月5日周二 上午8:36写道:

> Sorry for bad autocorrect in my last message.
>
> It depends on who owns the IP of the file. You should never remove or
> replace a 3rd party header from a file without their permission even if you
> have made changes.
>
> On Tue, 5 Nov 2019, 11:33 Justin Mclean, <ju...@classsoftware.com> wrote:
>
> > Hi,
> > It celebs who the filed necking to and who owns the IP on each file. The
> > release should be under the Apache license that's required.
> > Thanks,
> > Justin
> >
> > On Tue, 5 Nov 2019, 11:15 Zhiyuan Ju, <ju...@apache.org> wrote:
> >
> >> Hi Justin,
> >>
> >> Just to make sure, for the incubator-apisix-dashboard repo, all
> unchanged
> >> files should remove our ALv2 header and all significant
> >>  changes files will be added the ALv2 header, and the repo will keep the
> >> MIT License?
> >>
> >> Justin Mclean <ju...@classsoftware.com> 于 2019年11月4日周一 22:25写道:
> >>
> >> > Hi,
> >> >
> >> > > I have two issues about the dashboard license so far
> >> >
> >> > I replied to this before.
> >> >
> >> > > 1. The first one is the question mentioned in the email above:
> >> > >    how to deal with the license for frontend production build files
> in
> >> > > incubator-apisix-dashboard-built [1]?
> >> >
> >> > It ALv2 in an apache repo so what’s the issue?
> >> >
> >> > > 2. The second is that the dashboard is based on
> vue-element-admin[3],
> >> > > we need to carefully sort out which files should keep the original
> MIT
> >> > > license and which our modified files can add the apache license
> >> header.
> >> >
> >> > That's easy, all files should keep the original MIT license. If you
> have
> >> > permission from the owner you can change it, but otherwise unless
> their
> >> are
> >> > significant changes it is best to keep the original header and
> license.
> >> [1]
> >> >
> >> > Thanks,
> >> > Justin
> >> >
> >> > 1. https://www.apache.org/legal/src-headers.html#3party
> >>
> >
>

Re: [LICENSE] question about apisix-dashboard

Posted by Justin Mclean <ju...@classsoftware.com>.
Sorry for bad autocorrect in my last message.

It depends on who owns the IP of the file. You should never remove or
replace a 3rd party header from a file without their permission even if you
have made changes.

On Tue, 5 Nov 2019, 11:33 Justin Mclean, <ju...@classsoftware.com> wrote:

> Hi,
> It celebs who the filed necking to and who owns the IP on each file. The
> release should be under the Apache license that's required.
> Thanks,
> Justin
>
> On Tue, 5 Nov 2019, 11:15 Zhiyuan Ju, <ju...@apache.org> wrote:
>
>> Hi Justin,
>>
>> Just to make sure, for the incubator-apisix-dashboard repo, all unchanged
>> files should remove our ALv2 header and all significant
>>  changes files will be added the ALv2 header, and the repo will keep the
>> MIT License?
>>
>> Justin Mclean <ju...@classsoftware.com> 于 2019年11月4日周一 22:25写道:
>>
>> > Hi,
>> >
>> > > I have two issues about the dashboard license so far
>> >
>> > I replied to this before.
>> >
>> > > 1. The first one is the question mentioned in the email above:
>> > >    how to deal with the license for frontend production build files in
>> > > incubator-apisix-dashboard-built [1]?
>> >
>> > It ALv2 in an apache repo so what’s the issue?
>> >
>> > > 2. The second is that the dashboard is based on vue-element-admin[3],
>> > > we need to carefully sort out which files should keep the original MIT
>> > > license and which our modified files can add the apache license
>> header.
>> >
>> > That's easy, all files should keep the original MIT license. If you have
>> > permission from the owner you can change it, but otherwise unless their
>> are
>> > significant changes it is best to keep the original header and license.
>> [1]
>> >
>> > Thanks,
>> > Justin
>> >
>> > 1. https://www.apache.org/legal/src-headers.html#3party
>>
>

Re: [LICENSE] question about apisix-dashboard

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
It celebs who the filed necking to and who owns the IP on each file. The
release should be under the Apache license that's required.
Thanks,
Justin

On Tue, 5 Nov 2019, 11:15 Zhiyuan Ju, <ju...@apache.org> wrote:

> Hi Justin,
>
> Just to make sure, for the incubator-apisix-dashboard repo, all unchanged
> files should remove our ALv2 header and all significant
>  changes files will be added the ALv2 header, and the repo will keep the
> MIT License?
>
> Justin Mclean <ju...@classsoftware.com> 于 2019年11月4日周一 22:25写道:
>
> > Hi,
> >
> > > I have two issues about the dashboard license so far
> >
> > I replied to this before.
> >
> > > 1. The first one is the question mentioned in the email above:
> > >    how to deal with the license for frontend production build files in
> > > incubator-apisix-dashboard-built [1]?
> >
> > It ALv2 in an apache repo so what’s the issue?
> >
> > > 2. The second is that the dashboard is based on vue-element-admin[3],
> > > we need to carefully sort out which files should keep the original MIT
> > > license and which our modified files can add the apache license header.
> >
> > That's easy, all files should keep the original MIT license. If you have
> > permission from the owner you can change it, but otherwise unless their
> are
> > significant changes it is best to keep the original header and license.
> [1]
> >
> > Thanks,
> > Justin
> >
> > 1. https://www.apache.org/legal/src-headers.html#3party
>

Re: [LICENSE] question about apisix-dashboard

Posted by Zhiyuan Ju <ju...@apache.org>.
Hi Justin,

Just to make sure, for the incubator-apisix-dashboard repo, all unchanged
files should remove our ALv2 header and all significant
 changes files will be added the ALv2 header, and the repo will keep the
MIT License?

Justin Mclean <ju...@classsoftware.com> 于 2019年11月4日周一 22:25写道:

> Hi,
>
> > I have two issues about the dashboard license so far
>
> I replied to this before.
>
> > 1. The first one is the question mentioned in the email above:
> >    how to deal with the license for frontend production build files in
> > incubator-apisix-dashboard-built [1]?
>
> It ALv2 in an apache repo so what’s the issue?
>
> > 2. The second is that the dashboard is based on vue-element-admin[3],
> > we need to carefully sort out which files should keep the original MIT
> > license and which our modified files can add the apache license header.
>
> That's easy, all files should keep the original MIT license. If you have
> permission from the owner you can change it, but otherwise unless their are
> significant changes it is best to keep the original header and license. [1]
>
> Thanks,
> Justin
>
> 1. https://www.apache.org/legal/src-headers.html#3party

Re: [LICENSE] question about apisix-dashboard

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

> I have two issues about the dashboard license so far

I replied to this before.

> 1. The first one is the question mentioned in the email above:
>    how to deal with the license for frontend production build files in
> incubator-apisix-dashboard-built [1]?

It ALv2 in an apache repo so what’s the issue?

> 2. The second is that the dashboard is based on vue-element-admin[3],
> we need to carefully sort out which files should keep the original MIT
> license and which our modified files can add the apache license header.

That's easy, all files should keep the original MIT license. If you have permission from the owner you can change it, but otherwise unless their are significant changes it is best to keep the original header and license. [1]

Thanks,
Justin
 
1. https://www.apache.org/legal/src-headers.html#3party

Re: [LICENSE] question about apisix-dashboard

Posted by Ming Wen <we...@apache.org>.
Hi, Justin,
I have two issues about the dashboard license so far:
1. The first one is the question mentioned in the email above:
    how to deal with the license for frontend production build files in
incubator-apisix-dashboard-built [1]?
2. The second is that the dashboard is based on vue-element-admin[3],
we need to carefully sort out which files should keep the original MIT
license
and which our modified files can add the apache license header.

Zhiyuan is working on the second issue.
Zhiyuan is more familiar with the front end than I am,
please add more info if I didn't make it clear.

[1] https://github.com/apache/incubator-apisix-dashboard-built
[2] https://github.com/apache/incubator-apisix-dashboard
[3] https://github.com/PanJiaChen/vue-element-admin

Thanks,
Ming Wen, Apache APISIX
Twitter: _WenMing


Justin Mclean <ju...@classsoftware.com> 于2019年11月3日周日 下午3:24写道:

>
> Hi,
>
> > I think we need to spend more time to fix dashboard license issues,
>
> What issue exists here?
>
> Thanks,
> Justin
>

Re: [LICENSE] question about apisix-dashboard

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

> I think we need to spend more time to fix dashboard license issues,

What issue exists here?

Thanks,
Justin

Re: [LICENSE] question about apisix-dashboard

Posted by Ming Wen <we...@apache.org>.
hello, committers,

I think we need to spend more time to fix dashboard license issues,
so how about remove the dashboard submodule from APISIX repo [1] first,
and add back when we fix dashboard license issues?

By the way, APISIX still working properly without the dashboard submodule.

[1] https://github.com/apache/incubator-apisix

Thanks,
Ming Wen, Apache APISIX
Twitter: _WenMing


Ming Wen <we...@apache.org> 于2019年11月1日周五 下午4:13写道:

> hello, mentors,
>     We have two standalone repositories about dashboard:
> incubator-apisix-dashboard[1] and incubator-apisix-dashboard-built [2].
>     The first one is the source code of APISIX dashboard, and not
> including in APISIX repo [3];
> another one is the production build files from the first one through yarn,
> and bundle in APISIX repo as a submodule.
>
> so I am not sure which way to declare the license and copyright of the
> dashboard in APISIX is appropriate:
>     1. add incubator-apisix-dashboard's license, but APISIX does not
> contain the code of incubator-apisix-dashboard;
>     2. add incubator-apisix-dashboard and incubator-apisix-dashboard
> dependencies' licenses;
>     3. no license for dashboard.
>
>  Is there a better way to deal with the license for frontend production
> build files?
>
> [1] https://github.com/apache/incubator-apisix-dashboard
> [2] https://github.com/apache/incubator-apisix-dashboard-built
> [3] https://github.com/apache/incubator-apisix
>
> Thanks,
> Ming Wen, Apache APISIX
> Twitter: _WenMing
>