[GitHub] [airflow] siddharthvp commented on pull request #17891: Show error in UI when a DAG with same dag_id as another DAG is present

[GitBox <gi...@apache.org>]

siddharthvp commented on pull request #17891:
URL: https://github.com/apache/airflow/pull/17891#issuecomment-908299380


   Yes the logic is indeed hacky. 
   
   @uranusjr Even with the two solutions you suggest, the problem doesn't really go away (unless I'm much mistaken) - if a DAG is moved from one file to another in the middle of a parsing run and Airflow processed the source file before the rename occurred and the destination file after the rename, we still have a false-positive error. 
   
   So I think the only way to implement this feature would be via hacky heuristics. Maybe we should also change the exception text to clarify that it is a _possible_ duplication. When the next DAG parsing run occurs, the false-positive alert would go way. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org