You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/06/20 22:26:06 UTC

[GitHub] [hudi] zhedoubushishi commented on a diff in pull request #4915: [HUDI-3764] Allow loading external configs while querying Hudi tables with Spark

zhedoubushishi commented on code in PR #4915:
URL: https://github.com/apache/hudi/pull/4915#discussion_r902024959


##########
hudi-common/src/main/java/org/apache/hudi/common/config/DFSPropertiesConfiguration.java:
##########
@@ -174,6 +174,11 @@ public static TypedProperties getGlobalProps() {
     return globalProps;
   }
 
+  public static TypedProperties addToGlobalProps(String key, String value) {

Review Comment:
   `GLOBAL_PROPS` is a private variable so it is kind of hard to define it in the test class. I added a `test only` comments there.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org