You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Anthony Baker <ab...@apache.org> on 2016/01/26 18:47:49 UTC
Review Request 42808: GEODE-859: Modularize build script
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42808/
-----------------------------------------------------------
Review request for geode, Dick Cavender, Darrel Schneider, Mark Bretl, and Dan Smith.
Repository: geode
Description
-------
The root build.gradle script was getting unwieldy. This change
breaks the script into the following sections:
- code-analysis.gradle
- ide.gradle
- publish.gradle
- rat.gradle
- test.gradle
Each section should be relatively independent. For example, the
test script contains all the test dependencies.
Diffs
-----
Diff: https://reviews.apache.org/r/42808/diff/
Testing
-------
Thanks,
Anthony Baker
Re: Review Request 42808: GEODE-859: Modularize build script
Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42808/#review116389
-----------------------------------------------------------
Ship it!
Ship It!
- Jens Deppe
On Jan. 26, 2016, 5:54 p.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42808/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 5:54 p.m.)
>
>
> Review request for geode, Dick Cavender, Darrel Schneider, Mark Bretl, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The root build.gradle script was getting unwieldy. This change
> breaks the script into the following sections:
>
> - code-analysis.gradle
> - ide.gradle
> - publish.gradle
> - rat.gradle
> - test.gradle
>
> Each section should be relatively independent. For example, the
> test script contains all the test dependencies.
>
>
> Diffs
> -----
>
> build.gradle bd0ec18fa9eadc09b0c43c453a488b32291d7327
> gemfire-assembly/build.gradle 75805878d8d5c990af316cbb69ecdf8b1559aea3
> gradle/code-analysis.gradle PRE-CREATION
> gradle/ide.gradle PRE-CREATION
> gradle/java.gradle PRE-CREATION
> gradle/publish.gradle PRE-CREATION
> gradle/rat.gradle PRE-CREATION
> gradle/test.gradle PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42808/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>
Re: Review Request 42808: GEODE-859: Modularize build script
Posted by Mark Bretl <mb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42808/#review116435
-----------------------------------------------------------
Ship it!
It was only a matter of time for this task to be done. Excellent work.
- Mark Bretl
On Jan. 26, 2016, 9:54 a.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42808/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 9:54 a.m.)
>
>
> Review request for geode, Dick Cavender, Darrel Schneider, Mark Bretl, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The root build.gradle script was getting unwieldy. This change
> breaks the script into the following sections:
>
> - code-analysis.gradle
> - ide.gradle
> - publish.gradle
> - rat.gradle
> - test.gradle
>
> Each section should be relatively independent. For example, the
> test script contains all the test dependencies.
>
>
> Diffs
> -----
>
> build.gradle bd0ec18fa9eadc09b0c43c453a488b32291d7327
> gemfire-assembly/build.gradle 75805878d8d5c990af316cbb69ecdf8b1559aea3
> gradle/code-analysis.gradle PRE-CREATION
> gradle/ide.gradle PRE-CREATION
> gradle/java.gradle PRE-CREATION
> gradle/publish.gradle PRE-CREATION
> gradle/rat.gradle PRE-CREATION
> gradle/test.gradle PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42808/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>
Re: Review Request 42808: GEODE-859: Modularize build script
Posted by Dick Cavender <dc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42808/#review116422
-----------------------------------------------------------
Ship it!
Nice housekeeping! You da man!
- Dick Cavender
On Jan. 26, 2016, 5:54 p.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42808/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 5:54 p.m.)
>
>
> Review request for geode, Dick Cavender, Darrel Schneider, Mark Bretl, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The root build.gradle script was getting unwieldy. This change
> breaks the script into the following sections:
>
> - code-analysis.gradle
> - ide.gradle
> - publish.gradle
> - rat.gradle
> - test.gradle
>
> Each section should be relatively independent. For example, the
> test script contains all the test dependencies.
>
>
> Diffs
> -----
>
> build.gradle bd0ec18fa9eadc09b0c43c453a488b32291d7327
> gemfire-assembly/build.gradle 75805878d8d5c990af316cbb69ecdf8b1559aea3
> gradle/code-analysis.gradle PRE-CREATION
> gradle/ide.gradle PRE-CREATION
> gradle/java.gradle PRE-CREATION
> gradle/publish.gradle PRE-CREATION
> gradle/rat.gradle PRE-CREATION
> gradle/test.gradle PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42808/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>
Re: Review Request 42808: GEODE-859: Modularize build script
Posted by Anthony Baker <ab...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42808/
-----------------------------------------------------------
(Updated Jan. 26, 2016, 5:54 p.m.)
Review request for geode, Dick Cavender, Darrel Schneider, Mark Bretl, and Dan Smith.
Changes
-------
Adding the diffs back.
Repository: geode
Description
-------
The root build.gradle script was getting unwieldy. This change
breaks the script into the following sections:
- code-analysis.gradle
- ide.gradle
- publish.gradle
- rat.gradle
- test.gradle
Each section should be relatively independent. For example, the
test script contains all the test dependencies.
Diffs (updated)
-----
build.gradle bd0ec18fa9eadc09b0c43c453a488b32291d7327
gemfire-assembly/build.gradle 75805878d8d5c990af316cbb69ecdf8b1559aea3
gradle/code-analysis.gradle PRE-CREATION
gradle/ide.gradle PRE-CREATION
gradle/java.gradle PRE-CREATION
gradle/publish.gradle PRE-CREATION
gradle/rat.gradle PRE-CREATION
gradle/test.gradle PRE-CREATION
Diff: https://reviews.apache.org/r/42808/diff/
Testing
-------
Thanks,
Anthony Baker