[jira] [Commented] (WICKET-5548) Websocket initialization URL is not valid when filter is not mapped to root.

["Martin Grigorov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-5548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958096#comment-13958096 ] 

Martin Grigorov commented on WICKET-5548:
-----------------------------------------

Thanks for providing a patch !

Initially I thought that the patch is perfect but then I tested it with the Javax/JSR356 impl and the app failed.
The problem is that JSR356 doesn't pass the Upgrade connection to the Servlet Filters at all. So the newly added filterPrefix in the ws:// url breaks it.

I will think on a solution.

> Websocket initialization URL is not valid when filter is not mapped to root.
> ----------------------------------------------------------------------------
>
>                 Key: WICKET-5548
>                 URL: https://issues.apache.org/jira/browse/WICKET-5548
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-native-websocket
>    Affects Versions: 6.14.0
>            Reporter: Pi Chen Lin
>            Assignee: Martin Grigorov
>         Attachments: Added_fillterPrefix_to_websocket_url_.patch
>
>
> When configuration the WebSocketFilter to map to '/test/*'
> for example
> <code language="xml">
>     <filter-mapping>
> 		<filter-name>websocket.filter</filter-name>
> 		<url-pattern>/test/*</url-pattern>
> 	</filter-mapping>
> </code>
> Will result in not being able to establish a websocket connection, because of the following line in wicket-websocket-jquery.js :
> <code>
>   line 47: 				url = protocol + '//' + document.location.host + Wicket.WebSocket.contextPath + '/wicket/websocket';
> </code>
> This line doesn't take in account the filter mapping.



--
This message was sent by Atlassian JIRA
(v6.2#6252)