You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Zack Shoylev <no...@github.com> on 2014/03/21 19:49:02 UTC
[jclouds] Fixes potentially deleting a null server id. (#323)
You can merge this Pull Request by running:
git pull https://github.com/rackspace/jclouds delete-null-server-fix
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/323
-- Commit Summary --
* Fixes potentially deleting a null server id.
-- File Changes --
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/features/ServerApiLiveTest.java (12)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/323.patch
https://github.com/jclouds/jclouds/pull/323.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/323
Re: [jclouds] Fixes potentially deleting a null server id. (#323)
Posted by Andrew Phillips <no...@github.com>.
+1 - good to go for me!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/323#issuecomment-38316357
Re: [jclouds] Fixes potentially deleting a null server id. (#323)
Posted by Zack Shoylev <no...@github.com>.
Closed #323.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/323
Re: [jclouds] Fixes potentially deleting a null server id. (#323)
Posted by Zack Shoylev <no...@github.com>.
> I think we should be good just having this change on master..?
Agreed. Thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/323#issuecomment-38460370
Re: [jclouds] Fixes potentially deleting a null server id. (#323)
Posted by Zack Shoylev <no...@github.com>.
SInce this is just in the test, I am not sure this requires a backport....? Or should I backport anyways.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/323#issuecomment-38338000
Re: [jclouds] Fixes potentially deleting a null server id. (#323)
Posted by Zack Shoylev <no...@github.com>.
About to merge then
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/323#issuecomment-38318532
Re: [jclouds] Fixes potentially deleting a null server id. (#323)
Posted by Andrew Phillips <no...@github.com>.
> Or should I backport anyways.
I think we should be good just having this change on master..?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/323#issuecomment-38340841
Re: [jclouds] Fixes potentially deleting a null server id. (#323)
Posted by Andrew Phillips <no...@github.com>.
Thanks, @zack-shoylev!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/323#issuecomment-38313055
Re: [jclouds] Fixes potentially deleting a null server id. (#323)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #681](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/681/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/323#issuecomment-38316298
Re: [jclouds] Fixes potentially deleting a null server id. (#323)
Posted by Zack Shoylev <no...@github.com>.
merged
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/323#issuecomment-38336598
Re: [jclouds] Fixes potentially deleting a null server id. (#323)
Posted by Andrew Phillips <no...@github.com>.
> @@ -88,7 +88,9 @@ public void testCreateInAvailabilityZone() {
> Server server = serverApi.get(serverId);
> assertEquals(server.getStatus(), Server.Status.ACTIVE);
> } finally {
> - serverApi.delete(serverId);
> + if (serverId!=null) {
[minor] Add spaces, i.e. `(serverId != null)`?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/323/files#r10850674
Re: [jclouds] Fixes potentially deleting a null server id. (#323)
Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds #935](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/935/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/323#issuecomment-38315244
Re: [jclouds] Fixes potentially deleting a null server id. (#323)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1151](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1151/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/323#issuecomment-38316949