[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #4118: fs: Support the root file system attributes(mode, uid, gid and time)

[GitBox <gi...@apache.org>]

xiaoxiang781216 edited a comment on pull request #4118:
URL: https://github.com/apache/incubator-nuttx/pull/4118#issuecomment-879873200


   > Hi @xiaoxiang781216, this is a great improvement, kudos!!! How to add new users and groups to test it? 
   The patch will come in the next patchset:
   
   1. Support set gid/uid/time in vfs
   2. Support get/set in the individual fs one by one
   
   > Also it is not clear if this code will work for others MTD FS like SmartFS, I think it should be nice to add support to Attributes on SmartFS.
   
   Most file system don't save this info into inode, but read/write to the disk directly. The next patch will add callback to mount_operation_s to make it possible.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org