[GitHub] [whimsy] sebbASF commented on a change in pull request #133: Update parts.js.rb

[GitBox <gi...@apache.org>]

sebbASF commented on a change in pull request #133:
URL: https://github.com/apache/whimsy/pull/133#discussion_r810553377



##########
File path: www/secretary/workbench/views/actions/incomplete.json.rb
##########
@@ -15,6 +15,14 @@
 REASONS = {
   '@missing_address' => 'missing or incomplete postal address',
   '@missing_email' => 'missing email address',
+  '@@corporate_postal' => 'the postal address does not appear to be a personal postal address',

Review comment:
       @@ => @

##########
File path: www/secretary/workbench/views/parts.js.rb
##########
@@ -204,7 +220,7 @@ def render
             _label do
               _input type: 'radio', name: 'doctype', value: 'incomplete',
                 onClick: self.reject
-              _span 'incomplete form (select missing items below first)'
+              _span 'incomplete form (problematic items below)'

Review comment:
       Strictly speaking this is now not just for incomplete forms




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@whimsical.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org