[GitHub] [ignite-3] rpuch commented on a diff in pull request #2091: IGNITE-19396 Move work with indexes from StorageUpdateHandler to a separate class

["rpuch (via GitHub)" <gi...@apache.org>]

rpuch commented on code in PR #2091:
URL: https://github.com/apache/ignite-3/pull/2091#discussion_r1200126973


##########
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/index/IndexStorage.java:
##########
@@ -67,7 +67,7 @@ public interface IndexStorage {
     @Nullable RowId getNextRowIdToBuild() throws StorageException;
 
     /**
-     * Sets the row ID for which the index needs to be built, {@code null} means that the index is built.
+     * Sets the row ID for which the index needs to be build, {@code null} means that the index is build.

Review Comment:
   Let's revert this change, because 'to be built' seems to be the correct form ('built' is the 3rd form for 'to build')



##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/StorageUpdateHandler.java:
##########
@@ -195,11 +193,11 @@ public void handleUpdateAll(
     void executeBatchGc() {
         HybridTimestamp lwm = lowWatermark.getLowWatermark();
 
-        if (lwm == null || safeTimeTracker.current().compareTo(lwm) < 0) {
+        if (lwm == null || gcUpdateHandler.getSafeTimeTracker().current().compareTo(lwm) < 0) {

Review Comment:
   How about extracting the check to a method on GcUpdateHandler? It could be called `safeTimeBelow(HybridTimestamp lwm)` or similarly



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org