You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "eirikbakke (via GitHub)" <gi...@apache.org> on 2025/03/12 17:22:27 UTC
[PR] Smaller bug fixes in the editor libraries [netbeans]
eirikbakke opened a new pull request, #8324:
URL: https://github.com/apache/netbeans/pull/8324
Here are a few smaller bug fixes in the ide/editor.lib2 module, each in a separate commit (since they are independent of each other).
* For platform apps that use the THIN_LINE_CARET option, on HiDPI monitors, fix a paint bug where a pixel-thick line from the caret may remain outside the repaint area, leaving "cursor droppings" behind as the user types.
* Avoid a NullPointerException that could occur if an editor is closed while MacOS trackpad scrolling events are still coming in.
* Fix an editor repaint bug which could leave lines appearing duplicated. Easy to reproduce on plain text files; see the commit for reproduction steps.
<img width="1035" alt="image" src="https://github.com/user-attachments/assets/b203d8cb-04b1-449f-a39c-c153131eeb98" />
The cause was clear: An existing comment in o.n.modules.editor.lib2.view.ViewBuilder explains that "For valid firstReplace the current impl repaints whole line", but that repaint was in a block of code that was being skipped as an optimization (the "accurate span" calculation). The fix is to check for the "firstReplace" case and ensure that repaint() will be called regardless (via the checkLayoutUpdate method).
* When line wrapping is enabled, adjust the wrap line length so that the text caret can't end up completely outside the scroll viewport.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Smaller bug fixes in the editor libraries [netbeans]
Posted by "eirikbakke (via GitHub)" <gi...@apache.org>.
eirikbakke merged PR #8324:
URL: https://github.com/apache/netbeans/pull/8324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Smaller bug fixes in the editor libraries [netbeans]
Posted by "eirikbakke (via GitHub)" <gi...@apache.org>.
eirikbakke commented on PR #8324:
URL: https://github.com/apache/netbeans/pull/8324#issuecomment-2726553953
When I press "Merge pull request" I get a new prompt now that I haven't seen before:
<img width="939" alt="image" src="https://github.com/user-attachments/assets/7cf7a0a3-4e9d-4f2c-a6d4-8b046e739393" />
Is this the right way to merge? (In this particular PR's case I do want to keep the commits separate.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Smaller bug fixes in the editor libraries [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #8324:
URL: https://github.com/apache/netbeans/pull/8324#issuecomment-2726580970
Just looked into another project and there all options (plain merge, squash and merge and rebase and merge) are available and for merge it looks identical. The GUI makes sense when you come from git CLI client as for a non-ff merge a commit message is required there too. As the email is selectable, I assume that it will be correctly recorded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Smaller bug fixes in the editor libraries [netbeans]
Posted by "eirikbakke (via GitHub)" <gi...@apache.org>.
eirikbakke commented on PR #8324:
URL: https://github.com/apache/netbeans/pull/8324#issuecomment-2726552669
Thanks for testing and reviewing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Smaller bug fixes in the editor libraries [netbeans]
Posted by "eirikbakke (via GitHub)" <gi...@apache.org>.
eirikbakke commented on PR #8324:
URL: https://github.com/apache/netbeans/pull/8324#issuecomment-2726662672
Thanks! Yeah, I merged and it looks the same as other merged PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists