[GitHub] [incubator-druid] xvrl opened a new pull request #8392: Do not assume system classloader is URLClassLoader in Java 9+

[GitBox <gi...@apache.org>]

xvrl opened a new pull request #8392: Do not assume system classloader is URLClassLoader in Java 9+
URL: https://github.com/apache/incubator-druid/pull/8392
 
 
   * Fallback to parsing classpath for hadoop task in Java 9+
   In Java 9 and above we cannot assume that the system classloader is an
   instance of URLClassLoader. This change adds a fallback method to parse
   the system classpath in that case, and adds a unit test to validate it matches
   what JDK8 would do.
   
   Note: This has not been tested in an actual hadoop setup, so this is mostly
   to help us pass unit tests.
   
   * Remove granularity test of dubious value
   One of our granularity tests relies on system classloader being a URLClassLoaders to
   catch a bug related to class initialization and static initializers using a subclass (see
   https://github.com/apache/incubator-druid/issues/2979)
   This test was added to catch a potential regression, but it assumes we would add back
   the same type of static initializers to this specific class, so it seems to be of dubious value
   as a unit test and mostly serves to illustrate the bug.
   
   relates to #5589  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org