You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/14 08:09:13 UTC
[GitHub] [spark] MaxGekk opened a new pull request #31831: [SPARK-34737][SQL] Cast input float to double in `TIMESTAMP_SECONDS`
MaxGekk opened a new pull request #31831:
URL: https://github.com/apache/spark/pull/31831
### What changes were proposed in this pull request?
In the PR, I propose to cast the input float to double in the `SecondsToTimestamp` expression in the same way as in the `Cast` expression.
### Why are the changes needed?
To have the same results from `CAST(<float> AS TIMESTAMP)` and from `TIMESTAMP_SECONDS`:
```sql
spark-sql> SELECT CAST(16777215.0f AS TIMESTAMP);
1970-07-14 07:20:15
spark-sql> SELECT TIMESTAMP_SECONDS(16777215.0f);
1970-07-14 07:20:14.951424
```
### Does this PR introduce _any_ user-facing change?
Yes. After the changes:
```sql
spark-sql> SELECT TIMESTAMP_SECONDS(16777215.0f);
1970-07-14 07:20:15
```
### How was this patch tested?
By running new test:
```
$ build/sbt "test:testOnly *DateExpressionsSuite"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31831: [SPARK-34737][SQL] Cast input float to double in `TIMESTAMP_SECONDS`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31831:
URL: https://github.com/apache/spark/pull/31831#issuecomment-798876454
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40623/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #31831: [SPARK-34737][SQL] Cast input float to double in `TIMESTAMP_SECONDS`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #31831:
URL: https://github.com/apache/spark/pull/31831
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31831: [SPARK-34737][SQL] Cast input float to double in `TIMESTAMP_SECONDS`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31831:
URL: https://github.com/apache/spark/pull/31831#issuecomment-798874247
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40623/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31831: [SPARK-34737][SQL] Cast input float to double in `TIMESTAMP_SECONDS`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31831:
URL: https://github.com/apache/spark/pull/31831#issuecomment-799023418
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #31831: [SPARK-34737][SQL] Cast input float to double in `TIMESTAMP_SECONDS`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #31831:
URL: https://github.com/apache/spark/pull/31831#issuecomment-801331524
Here is the backport to 3.1: https://github.com/apache/spark/pull/31872
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #31831: [SPARK-34737][SQL] Cast input float to double in `TIMESTAMP_SECONDS`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #31831:
URL: https://github.com/apache/spark/pull/31831#issuecomment-801320619
I would like to backport this to `branch-3.1` if you don't mind.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #31831: [SPARK-34737][SQL] Cast input float to double in `TIMESTAMP_SECONDS`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #31831:
URL: https://github.com/apache/spark/pull/31831#issuecomment-798917264
@HyukjinKwon @cloud-fan @yaooqinn @gengliangwang Could you review this PR, please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31831: [SPARK-34737][SQL] Cast input float to double in `TIMESTAMP_SECONDS`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31831:
URL: https://github.com/apache/spark/pull/31831#issuecomment-798875241
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40623/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31831: [SPARK-34737][SQL] Cast input float to double in `TIMESTAMP_SECONDS`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31831:
URL: https://github.com/apache/spark/pull/31831#issuecomment-798871394
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31831: [SPARK-34737][SQL] Cast input float to double in `TIMESTAMP_SECONDS`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31831:
URL: https://github.com/apache/spark/pull/31831#issuecomment-798871394
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136040/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #31831: [SPARK-34737][SQL] Cast input float to double in `TIMESTAMP_SECONDS`
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #31831:
URL: https://github.com/apache/spark/pull/31831#issuecomment-798918049
LGTM~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org