[GitHub] [spark] cloud-fan commented on pull request #27627: [WIP][SPARK-28067][SQL] Fix incorrect results for decimal aggregate sum by returning null on decimal overflow

[GitBox <gi...@apache.org>]

cloud-fan commented on pull request #27627:
URL: https://github.com/apache/spark/pull/27627#issuecomment-636729872


   LGTM except a few minor comments. This changes the aggregate buffer of the sum function, which means the streaming state store format is also changed. We need to mention it in the migration guide and suggest users restart the stream if their query contains sum of decimals.
   
   cc @marmbrus  @zsxwing @HeartSaVioR @xuanyuanking @dongjoon-hyun Usually we need to backport correctness fixes, but this breaks the streaming checkpoint and I don't know if it affects the backport policy.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org