You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by so...@apache.org on 2006/01/30 04:16:48 UTC
svn commit: r373420 - /httpd/mod_smtpd/trunk/src/smtp_core.c
Author: soc-rian
Date: Sun Jan 29 19:16:47 2006
New Revision: 373420
URL: http://svn.apache.org/viewcvs?rev=373420&view=rev
Log:
some comments on the hooks.
Modified:
httpd/mod_smtpd/trunk/src/smtp_core.c
Modified: httpd/mod_smtpd/trunk/src/smtp_core.c
URL: http://svn.apache.org/viewcvs/httpd/mod_smtpd/trunk/src/smtp_core.c?rev=373420&r1=373419&r2=373420&view=diff
==============================================================================
--- httpd/mod_smtpd/trunk/src/smtp_core.c (original)
+++ httpd/mod_smtpd/trunk/src/smtp_core.c Sun Jan 29 19:16:47 2006
@@ -293,6 +293,8 @@
APR_HOOK_LINK(headers_parsed)
)
+/* mod_smtpd requires assistance from these hooks */
+
/* Implement 'smtpd_run_unrecognized_command'. */
APR_IMPLEMENT_EXTERNAL_HOOK_RUN_FIRST(smtpd, SMTPD, smtpd_retcode,
unrecognized_command,
@@ -300,22 +302,6 @@
char *data, smtpd_return_data **out_data),
(scr, command, data, out_data),
SMTPD_DECLINED);
-/* Implement 'smtpd_run_connect'. */
-/* it is an all hook because multiple plugins
- should be ale to perform actions on connect */
-APR_IMPLEMENT_EXTERNAL_HOOK_RUN_ALL(smtpd, SMTPD, smtpd_retcode, connect,
- (smtpd_session_rec *scr,
- smtpd_return_data **out_data),
- (scr, out_data),
- SMTPD_OK, SMTPD_DECLINED);
-/* Implement 'smtpd_run_reset_envelope'. */
-/* it is an all hook because multiple plugins
- should be able to perform actions on rset */
-APR_IMPLEMENT_EXTERNAL_HOOK_RUN_ALL(smtpd, SMTPD, smtpd_retcode,
- reset_envelope,
- (smtpd_session_rec *scr),
- (scr),
- SMTPD_OK, SMTPD_DECLINED);
/* Implement 'smtpd_run_helo'. */
APR_IMPLEMENT_EXTERNAL_HOOK_RUN_FIRST(smtpd, SMTPD, smtpd_retcode, helo,
(smtpd_session_rec *scr, char *str,
@@ -350,13 +336,6 @@
smtpd_return_data **out_data),
(scr, str, out_data),
SMTPD_DECLINED);
-/* Implement 'smtpd_run_quit'. */
-/* it is an all hook because multiple plugins
- should be able to perform actions on quit */
-APR_IMPLEMENT_EXTERNAL_HOOK_RUN_ALL(smtpd, SMTPD, smtpd_retcode, quit,
- (smtpd_session_rec *scr),
- (scr),
- SMTPD_OK, SMTPD_DECLINED);
/* Implement 'smtpd_run_data'. */
APR_IMPLEMENT_EXTERNAL_HOOK_RUN_FIRST(smtpd, SMTPD, smtpd_retcode, data,
(smtpd_session_rec *scr,
@@ -370,17 +349,34 @@
smtpd_return_data **out_data),
(scr, out_data),
SMTPD_DECLINED);
+
+/* these are "ALL" hooks because they are simply events and
+ mod_smtpd doesn't need assistance from them */
+
+/* Implement 'smtpd_run_connect'. */
+APR_IMPLEMENT_EXTERNAL_HOOK_RUN_ALL(smtpd, SMTPD, smtpd_retcode, connect,
+ (smtpd_session_rec *scr,
+ smtpd_return_data **out_data),
+ (scr, out_data),
+ SMTPD_OK, SMTPD_DECLINED);
+/* Implement 'smtpd_run_quit'. */
+APR_IMPLEMENT_EXTERNAL_HOOK_RUN_ALL(smtpd, SMTPD, smtpd_retcode, quit,
+ (smtpd_session_rec *scr),
+ (scr),
+ SMTPD_OK, SMTPD_DECLINED);
+/* Implement 'smtpd_run_reset_envelope'. */
+APR_IMPLEMENT_EXTERNAL_HOOK_RUN_ALL(smtpd, SMTPD, smtpd_retcode,
+ reset_envelope,
+ (smtpd_session_rec *scr),
+ (scr),
+ SMTPD_OK, SMTPD_DECLINED);
/* Implement 'smtpd_run_queue'. */
-/* it is an all hook because multiple plugins
- should be able to queue */
APR_IMPLEMENT_EXTERNAL_HOOK_RUN_ALL(smtpd, SMTPD, smtpd_retcode, queue,
(smtpd_session_rec *scr,
smtpd_return_data **out_data),
(scr, out_data),
SMTPD_OK, SMTPD_DECLINED);
/* Implement 'smtpd_run_headers_parsed'. */
-/* it is an all hook because multiple plugins
- should be able to perform actions */
APR_IMPLEMENT_EXTERNAL_HOOK_RUN_ALL(smtpd, SMTPD, smtpd_retcode,
headers_parsed,
(smtpd_session_rec *scr),