You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Uwe Schindler (Created) (JIRA)" <ji...@apache.org> on 2012/04/04 08:43:19 UTC
[jira] [Created] (LUCENE-3949) Fix license headers in all Java
files to not be in Javadocs /** format
Fix license headers in all Java files to not be in Javadocs /** format
----------------------------------------------------------------------
Key: LUCENE-3949
URL: https://issues.apache.org/jira/browse/LUCENE-3949
Project: Lucene - Java
Issue Type: Task
Reporter: Uwe Schindler
Fix For: 4.0
Our current License headers in all .java files are (for a reason I don't know) in Javadocs format. Means, when you have a class without javadocs, the License header is used as Javadocs.
I reviewed lots of other Apache projects, most of them use the correct /* header, but some (including Lucene+Solr) the Javadocs one. We should change this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3949) Fix license headers in all Java
files to not be in Javadocs /** format
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292331#comment-13292331 ]
Robert Muir commented on LUCENE-3949:
-------------------------------------
yes, I agree. I would re-run the script on 4.x branch (it has more files, e.g. preflex codec) and then just mark the rev merged with svn merge --record-only
> Fix license headers in all Java files to not be in Javadocs /** format
> ----------------------------------------------------------------------
>
> Key: LUCENE-3949
> URL: https://issues.apache.org/jira/browse/LUCENE-3949
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Uwe Schindler
> Assignee: Hoss Man
> Fix For: 4.0
>
> Attachments: LUCENE-3949.patch, fix-license-jdoc.pl
>
>
> Our current License headers in all .java files are (for a reason I don't know) in Javadocs format. Means, when you have a class without javadocs, the License header is used as Javadocs.
> I reviewed lots of other Apache projects, most of them use the correct /* header, but some (including Lucene+Solr) the Javadocs one. We should change this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3949) Fix license headers in all Java
files to not be in Javadocs /** format
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292321#comment-13292321 ]
Uwe Schindler commented on LUCENE-3949:
---------------------------------------
Commit this! Thanks!
> Fix license headers in all Java files to not be in Javadocs /** format
> ----------------------------------------------------------------------
>
> Key: LUCENE-3949
> URL: https://issues.apache.org/jira/browse/LUCENE-3949
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Uwe Schindler
> Assignee: Hoss Man
> Fix For: 4.0
>
> Attachments: LUCENE-3949.patch, fix-license-jdoc.pl
>
>
> Our current License headers in all .java files are (for a reason I don't know) in Javadocs format. Means, when you have a class without javadocs, the License header is used as Javadocs.
> I reviewed lots of other Apache projects, most of them use the correct /* header, but some (including Lucene+Solr) the Javadocs one. We should change this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-3949) Fix license headers in all Java
files to not be in Javadocs /** format
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hoss Man resolved LUCENE-3949.
------------------------------
Resolution: Fixed
Committed revision 1348980. - trunk
Committed revision 1348984. - 4x
> Fix license headers in all Java files to not be in Javadocs /** format
> ----------------------------------------------------------------------
>
> Key: LUCENE-3949
> URL: https://issues.apache.org/jira/browse/LUCENE-3949
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Uwe Schindler
> Assignee: Hoss Man
> Fix For: 4.0
>
> Attachments: LUCENE-3949.patch, fix-license-jdoc.pl
>
>
> Our current License headers in all .java files are (for a reason I don't know) in Javadocs format. Means, when you have a class without javadocs, the License header is used as Javadocs.
> I reviewed lots of other Apache projects, most of them use the correct /* header, but some (including Lucene+Solr) the Javadocs one. We should change this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Assigned] (LUCENE-3949) Fix license headers in all Java
files to not be in Javadocs /** format
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hoss Man reassigned LUCENE-3949:
--------------------------------
Assignee: Hoss Man
> Fix license headers in all Java files to not be in Javadocs /** format
> ----------------------------------------------------------------------
>
> Key: LUCENE-3949
> URL: https://issues.apache.org/jira/browse/LUCENE-3949
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Uwe Schindler
> Assignee: Hoss Man
> Fix For: 4.0
>
> Attachments: LUCENE-3949.patch, fix-license-jdoc.pl
>
>
> Our current License headers in all .java files are (for a reason I don't know) in Javadocs format. Means, when you have a class without javadocs, the License header is used as Javadocs.
> I reviewed lots of other Apache projects, most of them use the correct /* header, but some (including Lucene+Solr) the Javadocs one. We should change this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3949) Fix license headers in all Java
files to not be in Javadocs /** format
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264345#comment-13264345 ]
Robert Muir commented on LUCENE-3949:
-------------------------------------
I committed detection for the situation where 'javadocs is a license header' in r1331787.
These can be found with 'javadocs-lint' if you change it to "level=class" in lucene/build.xml
But of course there are classes also missing class javadocs completely to fix too so
we can't yet kick it on in hudson...
> Fix license headers in all Java files to not be in Javadocs /** format
> ----------------------------------------------------------------------
>
> Key: LUCENE-3949
> URL: https://issues.apache.org/jira/browse/LUCENE-3949
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Uwe Schindler
> Fix For: 4.0
>
>
> Our current License headers in all .java files are (for a reason I don't know) in Javadocs format. Means, when you have a class without javadocs, the License header is used as Javadocs.
> I reviewed lots of other Apache projects, most of them use the correct /* header, but some (including Lucene+Solr) the Javadocs one. We should change this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3949) Fix license headers in all Java
files to not be in Javadocs /** format
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292322#comment-13292322 ]
Uwe Schindler commented on LUCENE-3949:
---------------------------------------
...and backport (means not merging, but applying the script in 4.x branch, too)
> Fix license headers in all Java files to not be in Javadocs /** format
> ----------------------------------------------------------------------
>
> Key: LUCENE-3949
> URL: https://issues.apache.org/jira/browse/LUCENE-3949
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Uwe Schindler
> Assignee: Hoss Man
> Fix For: 4.0
>
> Attachments: LUCENE-3949.patch, fix-license-jdoc.pl
>
>
> Our current License headers in all .java files are (for a reason I don't know) in Javadocs format. Means, when you have a class without javadocs, the License header is used as Javadocs.
> I reviewed lots of other Apache projects, most of them use the correct /* header, but some (including Lucene+Solr) the Javadocs one. We should change this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3949) Fix license headers in all Java
files to not be in Javadocs /** format
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hoss Man updated LUCENE-3949:
-----------------------------
Attachment: LUCENE-3949.patch
fix-license-jdoc.pl
Here's a script to mass fix everything, and the monster patch file it produces on trunk. (3350 files modified!)
i haven't read the entire patch file but all the code & javadocs build cleanly, and (so far) the test are running fine.
Any objections to committing this on trunk and then svn merging back to 4x?
> Fix license headers in all Java files to not be in Javadocs /** format
> ----------------------------------------------------------------------
>
> Key: LUCENE-3949
> URL: https://issues.apache.org/jira/browse/LUCENE-3949
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Uwe Schindler
> Fix For: 4.0
>
> Attachments: LUCENE-3949.patch, fix-license-jdoc.pl
>
>
> Our current License headers in all .java files are (for a reason I don't know) in Javadocs format. Means, when you have a class without javadocs, the License header is used as Javadocs.
> I reviewed lots of other Apache projects, most of them use the correct /* header, but some (including Lucene+Solr) the Javadocs one. We should change this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org