[pinot] branch master updated: Config Validation: upsert table should not assign COMPLETED segments to different server (#11852)

[ja...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new 712c3e438b Config Validation: upsert table should not assign COMPLETED segments to different server (#11852)
712c3e438b is described below

commit 712c3e438b0d9c031ab68c8fbe12f2629434ddbc
Author: Kartik Khare <kh...@gmail.com>
AuthorDate: Wed Oct 25 23:05:48 2023 +0530

    Config Validation: upsert table should not assign COMPLETED segments to different server (#11852)
---
 .../java/org/apache/pinot/segment/local/utils/TableConfigUtils.java  | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java
index 2b9751b1b9..73cf7f27a1 100644
--- a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java
+++ b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java
@@ -723,6 +723,11 @@ public final class TableConfigUtils {
             "The delete record column must be a single-valued BOOLEAN column");
       }
     }
+
+    Preconditions.checkState(
+        tableConfig.getInstanceAssignmentConfigMap() == null || !tableConfig.getInstanceAssignmentConfigMap()
+            .containsKey(InstancePartitionsType.COMPLETED),
+        "InstanceAssignmentConfig for COMPLETED is not allowed for upsert tables");
     validateAggregateMetricsForUpsertConfig(tableConfig);
     validateTTLForUpsertConfig(tableConfig, schema);
   }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org