You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@bookkeeper.apache.org by "hangc0276 (via GitHub)" <gi...@apache.org> on 2023/05/25 08:02:17 UTC

[GitHub] [bookkeeper] hangc0276 commented on a diff in pull request #3968: Added support for OpenTelemetry metrics backend

hangc0276 commented on code in PR #3968:
URL: https://github.com/apache/bookkeeper/pull/3968#discussion_r1205098805


##########
pom.xml:
##########
@@ -71,6 +71,7 @@
     <module>tests</module>
     <module>native-io</module>
     <module>testtools</module>
+    <module>stats/bookkeeper-stats-providers/otel-metrics-provider</module>

Review Comment:
   We can make the module as the sub-module of `Apache BookKeeper :: Stats :: Parent` instead of the sub-module of the root.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org