You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "vkagamlyk (via GitHub)" <gi...@apache.org> on 2023/07/25 21:24:01 UTC

[GitHub] [tinkerpop] vkagamlyk commented on pull request #2157: TINKERPOP-2951: add translator to the Go GLV

vkagamlyk commented on PR #2157:
URL: https://github.com/apache/tinkerpop/pull/2157#issuecomment-1650581833

   Hi Itay,
   Thanks for your contribution!
   
   This PR is missing support for some types like integers other then `int`, bool, dates, collections, predicates, strategies, etc.
   
   For comprehensive list of test cases, please take a look [at translator tests for Python](https://github.com/apache/tinkerpop/blob/master/gremlin-python/src/main/python/tests/process/test_translator.py) or other GLV implementation.
   
   Would also be nice to mention this PR changes in [changelog](https://github.com/apache/tinkerpop/blob/master/CHANGELOG.asciidoc)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org