[GitHub] [netbeans] sdedic commented on a change in pull request #3296: [NETBEANS-3362] Show inherited members on the navigator pane

[GitBox <gi...@apache.org>]

sdedic commented on a change in pull request #3296:
URL: https://github.com/apache/netbeans/pull/3296#discussion_r741240081



##########
File path: ide/csl.api/src/org/netbeans/modules/csl/navigation/base/FiltersManager.java
##########
@@ -285,7 +291,18 @@ private void fireChange () {
             // notify listener
             lCopy.filterStateChanged(new ChangeEvent(FiltersManager.this));
         }
-    
+
+        @Override
+        public void removeNotify() {
+            // remember filter settings
+            if (null != filterStates) {
+                Preferences prefs = getPreferences();
+                for (String filterName : filterStates.keySet()) {
+                    prefs.putBoolean(filterName, filterStates.get(filterName));

Review comment:
       If the visible state should be persisted, then better save right after the toggle changes.

##########
File path: ide/csl.api/src/org/netbeans/modules/csl/api/StructureItem.java
##########
@@ -60,4 +60,15 @@
 
     }
 
+    public interface InheritedItem extends StructureItem {
+
+        /**
+         * Check whether this StructureItem is an inherited item.
+         *
+         * @since 2.72.0
+         * @return {@code true} if it is an inherited item, otherwise
+         * {@code false}
+         */
+        boolean isInherited();

Review comment:
       I'd suggest to extend this a little bit to provide e.g. `ElementHandle` (which should be equals/hashCode capable) to indicate declaring class/whatever of the inherited item. That could allow for future UI expansion like grouping stuff from the same source etc.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists